From patchwork Sat Dec 14 22:38:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 3349611 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1AAF7C0D4A for ; Sat, 14 Dec 2013 22:38:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 60BFD206A5 for ; Sat, 14 Dec 2013 22:38:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 85FBA206A1 for ; Sat, 14 Dec 2013 22:38:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFB46FB88A; Sat, 14 Dec 2013 14:38:48 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yh0-f41.google.com (mail-yh0-f41.google.com [209.85.213.41]) by gabe.freedesktop.org (Postfix) with ESMTP id E4880FB82D for ; Sat, 14 Dec 2013 14:38:45 -0800 (PST) Received: by mail-yh0-f41.google.com with SMTP id f11so2651644yha.14 for ; Sat, 14 Dec 2013 14:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UzfP337SaaUKM/1kabJxFl7d4ft2WHA1SuGlhG5uslY=; b=JF/mcO7pUxi4ZU1oqONfsUHs56ld/qpvHmn9WvJN3iELBhLvlo9iZ5ncA7aV/To9C6 ffV4GGfOQtr4ghYOc1nHaKN4UATz6flcyu30awnqNB0fMpqAeH/o84ltlx4p26m9PfnN X8NKyGb49E2ReOe2qXBWn+538b72rqvjHT9MMfSYe+vmy49XADIoCYa8n7X7USe7pX8Q D5NDbLdjR/Nyi70f6jy6Gm01vgIlD372aKX9YUZE1CrocKNR57TmughXNNZENDHfsRNI 2/K43rVPKxFsBKv9ggjaXO4A/ruxFOh1WVDr05QyC1FrMrj6Tbl8QIPt6Ay0Drjz4PNc BoCA== X-Received: by 10.236.178.69 with SMTP id e45mr749983yhm.119.1387060725579; Sat, 14 Dec 2013 14:38:45 -0800 (PST) Received: from localhost.localdomain ([177.140.135.10]) by mx.google.com with ESMTPSA id h23sm10544321yhc.0.2013.12.14.14.38.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 14:38:45 -0800 (PST) From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Sat, 14 Dec 2013 20:38:32 -0200 Message-Id: <1387060712-5081-6-git-send-email-rodrigo.vivi@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1387060712-5081-1-git-send-email-rodrigo.vivi@gmail.com> References: <1387060712-5081-1-git-send-email-rodrigo.vivi@gmail.com> Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Only use read-back pipe config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ca6cd5d..04efe1b 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9492,6 +9492,9 @@ check_crtc_state(struct drm_device *dev) intel_dump_pipe_config(crtc, &crtc->config, "[sw state]"); } + + /* Make sure our code only depends upon stuff we read back. */ + memcpy(&pipe_config, &crtc->config, sizeof(pipe_config)); } }