From patchwork Sat Dec 28 20:00:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Van Heukelum X-Patchwork-Id: 3414361 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 50C5F9F374 for ; Sat, 28 Dec 2013 20:08:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 917E52011B for ; Sat, 28 Dec 2013 20:08:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B31A72010F for ; Sat, 28 Dec 2013 20:08:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9ADDCFAA31 for ; Sat, 28 Dec 2013 12:08:09 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org X-Greylist: delayed 396 seconds by postgrey-1.32 at gabe; Sat, 28 Dec 2013 12:07:45 PST Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F94AFA8D4 for ; Sat, 28 Dec 2013 12:07:45 -0800 (PST) Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 4D26020F08 for ; Sat, 28 Dec 2013 15:01:09 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sat, 28 Dec 2013 15:01:09 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= mesmtp; bh=PZyBqA4ciVkcGNBkdLVVwxDaJaI=; b=bKPzmeNVMaWZfkT8qY4nZ XkDn5CDV8eH/qCz9We7dz1Q8yk5ADpPuJLxURzwIjCxwkt9PqGx6+MMJyR40bzBD bttakt9gs9tI5Exr+IfyV7Xonx6tBsXLRDIbdCBw7VpoLkyyjIt11Wva15JawXdn eMd350SPr7n0Y7qCzW5OzM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references; s=smtpout; bh=PZyBqA4ciVkcGNBkdLVVwxDaJ aI=; b=l1GqEG9i6ch0EZ3ySpS2mzwYyLz1d3ULxUlyHucX878UNq78uY1EbuGI5 Lg5mAIEPeH9a2F9kDDHyw7KGGEJB909xKnb+vfUOl3iWbOFHG1eTcyZDufuPvZRm m708T5SJXI+OtjbtCn2LQynrdd9tEljSMdNwXdHo7Zab8BGz78= X-Sasl-enc: UI7NQ57fD1NVLOCWmnHqC8wtrTa1cUe64gwEUvbKZ4a1 1388260868 Received: from 5810TZ.heukelum.dyn.dhs.org (unknown [83.83.55.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 16989C00E8D; Sat, 28 Dec 2013 15:01:07 -0500 (EST) From: Alexander van Heukelum To: Jani Nikula , Daniel Vetter , David Airlie Date: Sat, 28 Dec 2013 21:00:39 +0100 Message-Id: <1388260839-3873-2-git-send-email-heukelum@fastmail.fm> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1388260839-3873-1-git-send-email-heukelum@fastmail.fm> References: <1388260839-3873-1-git-send-email-heukelum@fastmail.fm> Cc: Alexander van Heukelum , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] Revert "drm/i915: assume all GM45 Acer laptops use inverted backlight PWM" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP My Acer 8510TZ stops displaying anything when X starts with Linus' current tree. I bisected it down to commit ee1452d74584. This patch reverts commit ee1452d74584. After the revert, everything works as before. Signed-off-by: Alexander van Heukelum Reported-by: Dylan Borg Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 54e82a8..769b864 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -10541,11 +10541,20 @@ static struct intel_quirk intel_quirks[] = { /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, - /* - * All GM45 Acer (and its brands eMachines and Packard Bell) laptops - * seem to use inverted backlight PWM. - */ - { 0x2a42, 0x1025, PCI_ANY_ID, quirk_invert_brightness }, + /* Acer Aspire 5734Z must invert backlight brightness */ + { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, + + /* Acer/eMachines G725 */ + { 0x2a42, 0x1025, 0x0210, quirk_invert_brightness }, + + /* Acer/eMachines e725 */ + { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, + + /* Acer/Packard Bell NCL20 */ + { 0x2a42, 0x1025, 0x034b, quirk_invert_brightness }, + + /* Acer Aspire 4736Z */ + { 0x2a42, 0x1025, 0x0260, quirk_invert_brightness }, /* Dell XPS13 HD Sandy Bridge */ { 0x0116, 0x1028, 0x052e, quirk_no_pcm_pwm_enable },