From patchwork Fri Jan 10 21:02:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesse Barnes X-Patchwork-Id: 3467991 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 231B1C02DC for ; Fri, 10 Jan 2014 21:02:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0872420121 for ; Fri, 10 Jan 2014 21:02:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0114C20131 for ; Fri, 10 Jan 2014 21:02:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18448FC4A8; Fri, 10 Jan 2014 13:02:34 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from alt-proxy13.mail.unifiedlayer.com (alt-proxy13.mail.unifiedlayer.com [67.222.34.81]) by gabe.freedesktop.org (Postfix) with SMTP id 1A4A4FC4A0 for ; Fri, 10 Jan 2014 13:02:32 -0800 (PST) Received: (qmail 22661 invoked by uid 0); 10 Jan 2014 21:02:29 -0000 Received: from unknown (HELO box514.bluehost.com) (74.220.219.114) by oproxy18.mail.unifiedlayer.com with SMTP; 10 Jan 2014 21:02:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuousgeek.org; s=default; h=Message-Id:Date:Subject:To:From; bh=EOh2hv+p/Sii+fEVzBg7HOiSfbdhfpysTNYKrQnDnVU=; b=m5WlbJuaJ/J/mxqvwpWEE7a8fone1zV44MwBxizch/sbCbuX6uvEEAPg/gyVwrLsoEm9HgfE8Rbx6eVtXsMlr9YEsbaCoNum5fZ4EtKBA/LP+NO+5iclUTUzvz3HQCK6; Received: from [67.161.37.189] (port=48773 helo=localhost.localdomain) by box514.bluehost.com with esmtpsa (UNKNOWN:CAMELLIA256-SHA:256) (Exim 4.80) (envelope-from ) id 1W1jDo-0006Mv-Vg for intel-gfx@lists.freedesktop.org; Fri, 10 Jan 2014 14:02:29 -0700 From: Jesse Barnes To: intel-gfx@lists.freedesktop.org Date: Fri, 10 Jan 2014 13:02:20 -0800 Message-Id: <1389387741-5384-1-git-send-email-jbarnes@virtuousgeek.org> X-Mailer: git-send-email 1.8.3.2 X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.161.37.189 authed with jbarnes@virtuousgeek.org} Subject: [Intel-gfx] [PATCH 1/2] drm/i915: make sure south port interrupts are enabled properly X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We were apparently relying on the defaults on BDW, which resulted in no hotplug or AUX interrupts. References: https://bugs.freedesktop.org/show_bug.cgi?id=72834 References: https://bugs.freedesktop.org/show_bug.cgi?id=72833 Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 261254a..f88e265 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2763,13 +2763,15 @@ static void ibx_irq_postinstall(struct drm_device *dev) mask = SDE_GMBUS | SDE_AUX_MASK | SDE_TRANSB_FIFO_UNDER | SDE_TRANSA_FIFO_UNDER | SDE_POISON; } else { - mask = SDE_GMBUS_CPT | SDE_AUX_MASK_CPT | SDE_ERROR_CPT; + mask = SDE_GMBUS_CPT | SDE_AUX_MASK_CPT | SDE_ERROR_CPT | + SDE_HOTPLUG_MASK_CPT; I915_WRITE(SERR_INT, I915_READ(SERR_INT)); } I915_WRITE(SDEIIR, I915_READ(SDEIIR)); I915_WRITE(SDEIMR, ~mask); + I915_WRITE(SDEIER, mask); } static void gen5_gt_irq_postinstall(struct drm_device *dev)