From patchwork Fri Jan 10 21:12:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jeff.mcgee@intel.com X-Patchwork-Id: 3468001 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F0E5AC02DC for ; Fri, 10 Jan 2014 21:06:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 128EA2012E for ; Fri, 10 Jan 2014 21:06:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4213820131 for ; Fri, 10 Jan 2014 21:06:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C24BF106AE6; Fri, 10 Jan 2014 13:06:33 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A934105792 for ; Fri, 10 Jan 2014 13:06:29 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 10 Jan 2014 13:06:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,640,1384329600"; d="scan'208";a="456898913" Received: from jeffdesk.fso.intel.com ([10.5.53.1]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2014 13:06:28 -0800 From: jeff.mcgee@intel.com To: intel-gfx@lists.freedesktop.org Date: Fri, 10 Jan 2014 15:12:30 -0600 Message-Id: <1389388353-29980-2-git-send-email-jeff.mcgee@intel.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1389388353-29980-1-git-send-email-jeff.mcgee@intel.com> References: <1389388353-29980-1-git-send-email-jeff.mcgee@intel.com> Subject: [Intel-gfx] [PATCH 1/4] pm_rps: Use unbuffered I/O on sysfs files X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff McGee Bionic C library may not re-read a buffered, read-only file which results in failure to monitor changes in gt_cur_freq_mhz. Signed-off-by: Jeff McGee --- tests/pm_rps.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index e8affdb..9123451 100644 --- a/tests/pm_rps.c +++ b/tests/pm_rps.c @@ -22,6 +22,7 @@ * * Authors: * Ben Widawsky + * Jeff McGee * */ @@ -66,7 +67,6 @@ static int readval(FILE *filp) int val; int scanned; - fflush(filp); rewind(filp); scanned = fscanf(filp, "%d", &val); igt_assert(scanned == 1); @@ -76,15 +76,11 @@ static int readval(FILE *filp) static int do_writeval(FILE *filp, int val, int lerrno) { - /* Must write twice to sysfs since the first one simply calculates the size and won't return the error */ int ret; rewind(filp); ret = fprintf(filp, "%d", val); - rewind(filp); - ret = fprintf(filp, "%d", val); if (ret && lerrno) igt_assert(errno = lerrno); - fflush(filp); return ret; } #define writeval(filp, val) do_writeval(filp, val, 0) @@ -146,6 +142,7 @@ igt_simple_main igt_assert(ret != -1); junk->filp = fopen(path, junk->mode); igt_require(junk->filp); + setbuf(junk->filp, NULL); val = readval(junk->filp); igt_assert(val >= 0);