From patchwork Fri Jan 10 21:12:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jeff.mcgee@intel.com X-Patchwork-Id: 3468021 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 42D80C02DC for ; Fri, 10 Jan 2014 21:06:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 014FE2012E for ; Fri, 10 Jan 2014 21:06:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DA59C20121 for ; Fri, 10 Jan 2014 21:06:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAC0C106AEA; Fri, 10 Jan 2014 13:06:41 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B4FB1105792 for ; Fri, 10 Jan 2014 13:06:29 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 10 Jan 2014 13:06:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,640,1384329600"; d="scan'208";a="456898921" Received: from jeffdesk.fso.intel.com ([10.5.53.1]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2014 13:06:29 -0800 From: jeff.mcgee@intel.com To: intel-gfx@lists.freedesktop.org Date: Fri, 10 Jan 2014 15:12:32 -0600 Message-Id: <1389388353-29980-4-git-send-email-jeff.mcgee@intel.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1389388353-29980-1-git-send-email-jeff.mcgee@intel.com> References: <1389388353-29980-1-git-send-email-jeff.mcgee@intel.com> Subject: [Intel-gfx] [PATCH 3/4] pm_rps: Fix test to target original min and max X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff McGee The goal of the test is to confirm that gt_cur_freq_mhz can be forced to the boundaries of the frequency range by collapsing gt_min_freq_mhz and gt_max_freq_mhz to the target value. But we miss testing the upper end of the range by targetting the current value of max after it has been set equal to min. So fix by targetting orginal max instead of current max. This correction exposes a problem in setfreq where min is always set to target before max, which should fail if the target value is greater than max. So fix that too. Signed-off-by: Jeff McGee --- tests/pm_rps.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index 69eeb81..c968ecb 100644 --- a/tests/pm_rps.c +++ b/tests/pm_rps.c @@ -101,8 +101,13 @@ static int do_writeval(FILE *filp, int val, int lerrno) static void setfreq(int val) { - writeval(stuff[MIN].filp, val); - writeval(stuff[MAX].filp, val); + if (val > fmax) { + writeval(stuff[MAX].filp, val); + writeval(stuff[MIN].filp, val); + } else { + writeval(stuff[MIN].filp, val); + writeval(stuff[MAX].filp, val); + } } static void checkit(void) @@ -166,11 +171,11 @@ igt_simple_main dumpit(); checkit(); - setfreq(fmin); + setfreq(origmin); if (verbose) dumpit(); restore_assert(fcur == fmin); - setfreq(fmax); + setfreq(origmax); if (verbose) dumpit(); restore_assert(fcur == fmax);