| Message ID | 1389388389-7008-1-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2014/1/10 Jesse Barnes <jbarnes@virtuousgeek.org>: > We were apparently relying on the defaults on BDW, which resulted in no > hotplug or AUX interrupts. So be sure to call the ibx_irq_preinstall to > enable all interrupts. > > v2: use preinstall instead of redundant SDIER write > > References: https://bugs.freedesktop.org/show_bug.cgi?id=72834 > References: https://bugs.freedesktop.org/show_bug.cgi?id=72833 > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> And this should probably go to Kernel 3.13 too, right? Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > --- > drivers/gpu/drm/i915/i915_irq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 261254a..69b0b71 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2714,6 +2714,8 @@ static void gen8_irq_preinstall(struct drm_device *dev) > #undef GEN8_IRQ_INIT_NDX > > POSTING_READ(GEN8_PCU_IIR); > + > + ibx_irq_preinstall(dev); > } > > static void ibx_hpd_irq_setup(struct drm_device *dev) > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, 10 Jan 2014 19:17:02 -0200 Paulo Zanoni <przanoni@gmail.com> wrote: > 2014/1/10 Jesse Barnes <jbarnes@virtuousgeek.org>: > > We were apparently relying on the defaults on BDW, which resulted in no > > hotplug or AUX interrupts. So be sure to call the ibx_irq_preinstall to > > enable all interrupts. > > > > v2: use preinstall instead of redundant SDIER write > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=72834 > > References: https://bugs.freedesktop.org/show_bug.cgi?id=72833 > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > And this should probably go to Kernel 3.13 too, right? > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Yeah probably. Daniel, please cc:stable Thanks,
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 261254a..69b0b71 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2714,6 +2714,8 @@ static void gen8_irq_preinstall(struct drm_device *dev) #undef GEN8_IRQ_INIT_NDX POSTING_READ(GEN8_PCU_IIR); + + ibx_irq_preinstall(dev); } static void ibx_hpd_irq_setup(struct drm_device *dev)
We were apparently relying on the defaults on BDW, which resulted in no hotplug or AUX interrupts. So be sure to call the ibx_irq_preinstall to enable all interrupts. v2: use preinstall instead of redundant SDIER write References: https://bugs.freedesktop.org/show_bug.cgi?id=72834 References: https://bugs.freedesktop.org/show_bug.cgi?id=72833 Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 insertions(+)