diff mbox

[1/3] drm/i915: Tune down output when context is banned

Message ID 1389968431-24123-1-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Jan. 17, 2014, 2:20 p.m. UTC 
Demote DRM_ERROR to DRM_INFO when context is banned.

Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73652
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson Jan. 17, 2014, 2:27 p.m. UTC | #1 
On Fri, Jan 17, 2014 at 04:20:29PM +0200, Mika Kuoppala wrote:
> Demote DRM_ERROR to DRM_INFO when context is banned.

I am happy with this as we have a separate error message for when the
GPU is truly wedged. However, I feel that if the global context is
banned, that does deserve an error, at least a warning. Ok, not
quite so happy. 
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 5fcdb14..d270351 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2313,7 +2313,7 @@  static bool i915_context_is_banned(const struct i915_ctx_hang_stats *hs)
 		return true;
 
 	if (elapsed <= DRM_I915_CTX_BAN_PERIOD) {
-		DRM_ERROR("context hanging too fast, declaring banned!\n");
+		DRM_INFO("context hanging too fast, declaring banned!\n");
 		return true;
 	}