diff mbox

[Inte-gpu-tools,1/5] Assembler/bdw: Remove the unsupported cache agent for WRITE(...)

Message ID 1390874030-2687-1-git-send-email-yakui.zhao@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zhao, Yakui Jan. 28, 2014, 1:53 a.m. UTC 
From: Zhao Yakui <yakui.zhao@intel.com>

The Sampler/Constant cache is read-only. And it can't be used as
the target cache agent of WRITE message.

Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
---
 assembler/gram.y | 4 ----
 1 file changed, 4 deletions(-)

Comments

Xiang, Haihao Feb. 13, 2014, 3:10 a.m. UTC | #1 
On Tue, 2014-01-28 at 09:53 +0800, yakui.zhao@intel.com wrote: 
> From: Zhao Yakui <yakui.zhao@intel.com>
> 
> The Sampler/Constant cache is read-only. And it can't be used as
> the target cache agent of WRITE message.
> 
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
>  assembler/gram.y | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/assembler/gram.y b/assembler/gram.y
> index ad4cb29..589a0fe 100644
> --- a/assembler/gram.y
> +++ b/assembler/gram.y
> @@ -1652,9 +1652,7 @@ msgtarget:	NULL_TOKEN
>  		{
>  		  if (IS_GENp(8)) {
>                        if ($9 != 0 &&
> -			  $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
>  			  $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
> -			  $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
>  			  $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
>  			  $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
>  			  error (&@9, "error: wrong cache type\n");
> @@ -1715,9 +1713,7 @@ msgtarget:	NULL_TOKEN
>  		{
>  		  if (IS_GENp(8)) {
>                        if ($9 != 0 &&
> -			  $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
>  			  $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
> -			  $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
>  			  $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
>  			  $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
>  			  error (&@9, "error: wrong cache type\n");

It is OK for me

Reviewed-by: Xiang, Haihao <haihao.xiang@intel.com>
Lespiau, Damien Feb. 13, 2014, 7:55 a.m. UTC | #2 
On Thu, Feb 13, 2014 at 11:10:00AM +0800, Xiang, Haihao wrote:
> On Tue, 2014-01-28 at 09:53 +0800, yakui.zhao@intel.com wrote: 
> > From: Zhao Yakui <yakui.zhao@intel.com>
> > 
> > The Sampler/Constant cache is read-only. And it can't be used as
> > the target cache agent of WRITE message.
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> 
> It is OK for me
> 
> Reviewed-by: Xiang, Haihao <haihao.xiang@intel.com>
 
Pushed, thanks for the patch & review.
diff mbox

Patch

diff --git a/assembler/gram.y b/assembler/gram.y
index ad4cb29..589a0fe 100644
--- a/assembler/gram.y
+++ b/assembler/gram.y
@@ -1652,9 +1652,7 @@  msgtarget:	NULL_TOKEN
 		{
 		  if (IS_GENp(8)) {
                       if ($9 != 0 &&
-			  $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
 			  $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
-			  $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
 			  $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
 			  $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
 			  error (&@9, "error: wrong cache type\n");
@@ -1715,9 +1713,7 @@  msgtarget:	NULL_TOKEN
 		{
 		  if (IS_GENp(8)) {
                       if ($9 != 0 &&
-			  $9 != GEN6_SFID_DATAPORT_SAMPLER_CACHE &&
 			  $9 != GEN6_SFID_DATAPORT_RENDER_CACHE &&
-			  $9 != GEN6_SFID_DATAPORT_CONSTANT_CACHE &&
 			  $9 != GEN7_SFID_DATAPORT_DATA_CACHE &&
 			  $9 != HSW_SFID_DATAPORT_DATA_CACHE1) {
 			  error (&@9, "error: wrong cache type\n");