From patchwork Thu Jan 30 16:58:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 3558201 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2D058C02DC for ; Thu, 30 Jan 2014 16:59:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 35DB5201BC for ; Thu, 30 Jan 2014 16:59:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0C6F220181 for ; Thu, 30 Jan 2014 16:59:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFCDB11F58D; Thu, 30 Jan 2014 08:59:00 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A37E11F593 for ; Thu, 30 Jan 2014 08:58:45 -0800 (PST) Received: by mail-ee0-f50.google.com with SMTP id d17so1710063eek.23 for ; Thu, 30 Jan 2014 08:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=4Q9ruw0jPJ8yDDJEIvdeh/gYutph6BxCZESp2HW/3X0=; b=Z2Q2RlpxeJ/jFc/IntXbOT8umnsVfohDHuYa1bEGF1Nax9w7rMSi4OLXJV1pntZ8u3 cly/ncrksb/g9aGVCOzmp0kEZ11HYP/AhGjlibnaZD71/2pIm/KztHEZN54vAed5io35 YBaPf4PP8zB+tvarsj/hv2NTVj2t4d/2tlMNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4Q9ruw0jPJ8yDDJEIvdeh/gYutph6BxCZESp2HW/3X0=; b=EQZUnpPi8DQp3si+RNxoFjY3798ZE83d3q3vC3jCbK0eG4lV+hWqosQbqy2zrEzFm8 dwj2Q7NUPZoHRmP1SiIT3HjEeJ07CWwTE5pRzQl86xJqgNcWq6pZx9DPgNy8Tqb1cVah 7su8vrV+yZJ/k/6QjZ1x5SaXisPImgcrsKqeHKDxRipLQ+ywc/EqMuJYY8q5VAhF7uT2 wqoROBTO6NzbmbXsdTdgK4frKfxR1lbNdWZzua61mz9NneJLf8SpKLHY9wdqu0HXQ0SR rM3dJz0a71Z7TdZnEnRjUkB31LmNqxV2jum/SuJNv5enUJ3BQxFSfy3JpwnleOzL/yZu /0tg== X-Gm-Message-State: ALoCoQkKGIUCKEnLsMgnsfwbqSWIn5vywoZ/MH9qx8UA3fzdkCSd3ucwpZ/K/8XeQNTLxGC9IbuD X-Received: by 10.14.98.129 with SMTP id v1mr18350089eef.5.1391101125034; Thu, 30 Jan 2014 08:58:45 -0800 (PST) Received: from phenom.ffwll.local (84-73-67-144.dclient.hispeed.ch. [84.73.67.144]) by mx.google.com with ESMTPSA id b41sm24790580eef.16.2014.01.30.08.58.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Jan 2014 08:58:44 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 30 Jan 2014 17:58:38 +0100 Message-Id: <1391101118-29633-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.5.2 Cc: Daniel Vetter , Intel Graphics Development , David Herrmann , Dave Airlie , Dave Jones Subject: [Intel-gfx] [PATCH] drm: Fix use-after-free in the shadow-attache exit code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This regression has been introduced in commit b3f2333de8e81b089262b26d52272911523e605f Author: Daniel Vetter Date: Wed Dec 11 11:34:31 2013 +0100 drm: restrict the device list for shadow attached drivers Reported-by: Dave Jones Cc: Dave Jones Cc: Dave Airlie Cc: David Herrmann Signed-off-by: Daniel Vetter Reviewed-by: David Herrmann --- drivers/gpu/drm/drm_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 5736aaa7e86c..f7af69bcf3f4 100644 --- a/drivers/gpu/drm/drm_pci.c +++ b/drivers/gpu/drm/drm_pci.c @@ -468,8 +468,8 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver) } else { list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list, legacy_dev_list) { - drm_put_dev(dev); list_del(&dev->legacy_dev_list); + drm_put_dev(dev); } } DRM_INFO("Module unloaded\n");