| Message ID | 1395279079-12704-3-git-send-email-benjamin.widawsky@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 19, 2014 at 06:31:09PM -0700, Ben Widawsky wrote: > Introduced: > commit b8a5ff8d7c676a04e0da5ec16bb068dd39459042 > Author: Jeff McGee <jeff.mcgee@intel.com> > Date: Tue Feb 4 11:37:01 2014 -0600 > > drm/i915: Update rps interrupt limits > > Cc: Jeff McGee <jeff.mcgee@intel.com> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> The trailing {} is overkill, but forgivable :-p Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Thursday 20 March 2014 07:01 AM, Ben Widawsky wrote: > Introduced: > commit b8a5ff8d7c676a04e0da5ec16bb068dd39459042 > Author: Jeff McGee <jeff.mcgee@intel.com> > Date: Tue Feb 4 11:37:01 2014 -0600 > > drm/i915: Update rps interrupt limits > > Cc: Jeff McGee <jeff.mcgee@intel.com> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> > --- > drivers/gpu/drm/i915/i915_sysfs.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c > index 0c741f4..e9ffefb 100644 > --- a/drivers/gpu/drm/i915/i915_sysfs.c > +++ b/drivers/gpu/drm/i915/i915_sysfs.c > @@ -356,12 +356,12 @@ static ssize_t gt_max_freq_mhz_store(struct device *kdev, > valleyview_set_rps(dev, val); > else > gen6_set_rps(dev, val); > - } > - else if (!IS_VALLEYVIEW(dev)) > - /* We still need gen6_set_rps to process the new max_delay > - and update the interrupt limits even though frequency > - request is unchanged. */ > + } else if (!IS_VALLEYVIEW(dev)) { > + /* We still need gen6_set_rps to process the new max_delay and > + * update the interrupt limits even though frequency request is > + * unchanged. */ > gen6_set_rps(dev, dev_priv->rps.cur_delay); > + } > > mutex_unlock(&dev_priv->rps.hw_lock); > > @@ -430,12 +430,12 @@ static ssize_t gt_min_freq_mhz_store(struct device *kdev, > valleyview_set_rps(dev, val); > else > gen6_set_rps(dev, val); > - } > - else if (!IS_VALLEYVIEW(dev)) > - /* We still need gen6_set_rps to process the new min_delay > - and update the interrupt limits even though frequency > - request is unchanged. */ > + } else if (!IS_VALLEYVIEW(dev)) { > + /* We still need gen6_set_rps to process the new min_delay and > + * update the interrupt limits even though frequency request is > + * unchanged. */ > gen6_set_rps(dev, dev_priv->rps.cur_delay); > + } > > mutex_unlock(&dev_priv->rps.hw_lock); > Reviewed-by: Deepak S <deepak.s@linux.intel.com> Reviewed-by: Deepak S <deepak.s@linux.intel.com>
diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c index 0c741f4..e9ffefb 100644 --- a/drivers/gpu/drm/i915/i915_sysfs.c +++ b/drivers/gpu/drm/i915/i915_sysfs.c @@ -356,12 +356,12 @@ static ssize_t gt_max_freq_mhz_store(struct device *kdev, valleyview_set_rps(dev, val); else gen6_set_rps(dev, val); - } - else if (!IS_VALLEYVIEW(dev)) - /* We still need gen6_set_rps to process the new max_delay - and update the interrupt limits even though frequency - request is unchanged. */ + } else if (!IS_VALLEYVIEW(dev)) { + /* We still need gen6_set_rps to process the new max_delay and + * update the interrupt limits even though frequency request is + * unchanged. */ gen6_set_rps(dev, dev_priv->rps.cur_delay); + } mutex_unlock(&dev_priv->rps.hw_lock); @@ -430,12 +430,12 @@ static ssize_t gt_min_freq_mhz_store(struct device *kdev, valleyview_set_rps(dev, val); else gen6_set_rps(dev, val); - } - else if (!IS_VALLEYVIEW(dev)) - /* We still need gen6_set_rps to process the new min_delay - and update the interrupt limits even though frequency - request is unchanged. */ + } else if (!IS_VALLEYVIEW(dev)) { + /* We still need gen6_set_rps to process the new min_delay and + * update the interrupt limits even though frequency request is + * unchanged. */ gen6_set_rps(dev, dev_priv->rps.cur_delay); + } mutex_unlock(&dev_priv->rps.hw_lock);
Introduced: commit b8a5ff8d7c676a04e0da5ec16bb068dd39459042 Author: Jeff McGee <jeff.mcgee@intel.com> Date: Tue Feb 4 11:37:01 2014 -0600 drm/i915: Update rps interrupt limits Cc: Jeff McGee <jeff.mcgee@intel.com> Signed-off-by: Ben Widawsky <ben@bwidawsk.net> --- drivers/gpu/drm/i915/i915_sysfs.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)