diff mbox

[1/3] drm/i915: Catch abuse of I915_EXEC_GEN7_SOL_RESET

Message ID 1398277940-25676-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter April 23, 2014, 6:32 p.m. UTC
Currently we catch it, but silently succeed. Our userspace is
better than this.

Testcase: igt/gem_exec_params/sol-reset-*
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 0ec8621eb4f8..40ae5ff0a031 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -982,7 +982,7 @@  i915_reset_gen7_sol_offsets(struct drm_device *dev,
 	int ret, i;
 
 	if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS])
-		return 0;
+		return -EINVAL;
 
 	ret = intel_ring_begin(ring, 4 * 3);
 	if (ret)