diff mbox

configure: Don't link the driver against libX11

Message ID 1401805606-23455-1-git-send-email-ajax@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Jackson June 3, 2014, 2:26 p.m. UTC 
78dc0c04745ad4485b994f67833f4a155749f01d added REQUIRED_MODULES to the
driver link line for... some reason.  That pulled in the libs from the
XF86DRI check, which near as I can tell has always been wrong, all of
the other extension checks just look for the protocol module and
xextproto doesn't define dri1 protocol in any case.

Signed-off-by: Adam Jackson <ajax@redhat.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson June 3, 2014, 2:53 p.m. UTC | #1 
On Tue, Jun 03, 2014 at 10:26:46AM -0400, Adam Jackson wrote:
> 78dc0c04745ad4485b994f67833f4a155749f01d added REQUIRED_MODULES to the
> driver link line for... some reason.  That pulled in the libs from the
> XF86DRI check, which near as I can tell has always been wrong, all of
> the other extension checks just look for the protocol module and
> xextproto doesn't define dri1 protocol in any case.
> 
> Signed-off-by: Adam Jackson <ajax@redhat.com>

Thanks, pushed. I then took it a step further and dropped xf86driproto
from our `pkg-config $REQUIRED_MODULES` check and made it only required
for DRI support with i810.
-Chris
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 353f942..30bed3e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -330,7 +330,7 @@  fi
 # Store the list of server defined optional extensions in REQUIRED_MODULES
 XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
 XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
-XORG_DRIVER_CHECK_EXT(XF86DRI, xextproto x11)
+XORG_DRIVER_CHECK_EXT(XF86DRI, xf86driproto)
 XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
 
 # Obtain compiler/linker options for the driver dependencies