| Message ID | 1403158287-20084-1-git-send-email-sonika.jindal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 19, 2014 at 11:41:27AM +0530, sonika.jindal@intel.com wrote: > From: Sagar Kamble <sagar.a.kamble@intel.com> > > Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION) > Cc: linux-kernel@vger.kernel.org (open list) > --- > Documentation/DocBook/drm.tmpl | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl > index 7df3134..ce11fd7 100644 > --- a/Documentation/DocBook/drm.tmpl > +++ b/Documentation/DocBook/drm.tmpl > @@ -2664,11 +2664,13 @@ void intel_crt_init(struct drm_device *dev) > <td valign="top" >TBD</td> > </tr> > <tr> > - <td valign="top" >Standard name as in DRM</td> > - <td valign="top" >Standard type as in DRM</td> > - <td valign="top" >Standard value as in DRM</td> > - <td valign="top" >Standard Object as in DRM</td> > - <td valign="top" >TBD</td> > + <td valign="top" >“rotation”</td> > + <td valign="top" >BITMASK</td> > + <td valign="top" >{ 0, "rotate-0" }, > + { 2, "rotate-180" }</td> Remove new line? > + <td valign="top" >Plane</td> > + <td valign="top" >Used to set plane rotation. Only 0 and 180 degree > + rotation supported as of now</td> > </tr> > <tr> > <td rowspan="17" valign="top" >SDVO-TV</td> So, you've spotted that weird line with "Standard * as in DRM". I agree that it looks out of place. However if you want to make that change, you need to fix the whole table (this line appears elsewhere as well) and that's a separate change from adding the documentation for the rotation propery (ie different patch). Now can we as well: - Put the property under a Plane group - Your description doesn't add any information that isn't already in the previous fields, might as well say nothing there. Thanks,
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index 7df3134..ce11fd7 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -2664,11 +2664,13 @@ void intel_crt_init(struct drm_device *dev) <td valign="top" >TBD</td> </tr> <tr> - <td valign="top" >Standard name as in DRM</td> - <td valign="top" >Standard type as in DRM</td> - <td valign="top" >Standard value as in DRM</td> - <td valign="top" >Standard Object as in DRM</td> - <td valign="top" >TBD</td> + <td valign="top" >“rotation”</td> + <td valign="top" >BITMASK</td> + <td valign="top" >{ 0, "rotate-0" }, + { 2, "rotate-180" }</td> + <td valign="top" >Plane</td> + <td valign="top" >Used to set plane rotation. Only 0 and 180 degree + rotation supported as of now</td> </tr> <tr> <td rowspan="17" valign="top" >SDVO-TV</td>