diff mbox

[3/4] drm/i915/bdw: Remove the HDMI/DVI entry from the DP/eDP/FDI tables

Message ID 1406887677-3355-4-git-send-email-damien.lespiau@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lespiau, Damien Aug. 1, 2014, 10:07 a.m. UTC
We always write entries 0 to 8 from the DDI translation tables and then
entry 9 for HDMI/DVI with the help of the VBT. We then don't need the
failsafe HDMI entry in the DP/eDP/FDI tables.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Paulo Zanoni Aug. 1, 2014, 3:28 p.m. UTC | #1
2014-08-01 7:07 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> We always write entries 0 to 8 from the DDI translation tables and then
> entry 9 for HDMI/DVI with the help of the VBT. We then don't need the
> failsafe HDMI entry in the DP/eDP/FDI tables.

And it seems we were not even using these values anyway...

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 67feea2..80526ab 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -82,7 +82,6 @@ static const u32 bdw_ddi_translations_edp[] = {
>         0x00BEEFFF, 0x000A000C,
>         0x00FFFFFF, 0x0005000F,
>         0x00DB6FFF, 0x000A000C,
> -       0x00FFFFFF, 0x00140006          /* HDMI parameters 800mV 0dB*/
>  };
>
>  static const u32 bdw_ddi_translations_dp[] = {
> @@ -95,7 +94,6 @@ static const u32 bdw_ddi_translations_dp[] = {
>         0x80CB2FFF, 0x001B0002,
>         0x00F7DFFF, 0x00180004,
>         0x80D75FFF, 0x001B0002,
> -       0x00FFFFFF, 0x00140006          /* HDMI parameters 800mV 0dB*/
>  };
>
>  static const u32 bdw_ddi_translations_fdi[] = {
> @@ -108,7 +106,6 @@ static const u32 bdw_ddi_translations_fdi[] = {
>         0x00C30FFF, 0x000C0000,
>         0x00FFFFFF, 0x00070006,
>         0x00D75FFF, 0x000C0000,
> -       0x00FFFFFF, 0x00140006          /* HDMI parameters 800mV 0dB*/
>  };
>
>  static const u32 bdw_ddi_translations_hdmi[] = {
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 67feea2..80526ab 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -82,7 +82,6 @@  static const u32 bdw_ddi_translations_edp[] = {
 	0x00BEEFFF, 0x000A000C,
 	0x00FFFFFF, 0x0005000F,
 	0x00DB6FFF, 0x000A000C,
-	0x00FFFFFF, 0x00140006		/* HDMI parameters 800mV 0dB*/
 };
 
 static const u32 bdw_ddi_translations_dp[] = {
@@ -95,7 +94,6 @@  static const u32 bdw_ddi_translations_dp[] = {
 	0x80CB2FFF, 0x001B0002,
 	0x00F7DFFF, 0x00180004,
 	0x80D75FFF, 0x001B0002,
-	0x00FFFFFF, 0x00140006		/* HDMI parameters 800mV 0dB*/
 };
 
 static const u32 bdw_ddi_translations_fdi[] = {
@@ -108,7 +106,6 @@  static const u32 bdw_ddi_translations_fdi[] = {
 	0x00C30FFF, 0x000C0000,
 	0x00FFFFFF, 0x00070006,
 	0x00D75FFF, 0x000C0000,
-	0x00FFFFFF, 0x00140006		/* HDMI parameters 800mV 0dB*/
 };
 
 static const u32 bdw_ddi_translations_hdmi[] = {