| Message ID | 1409685827-29067-3-git-send-email-gustavo@padovan.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 02, 2014 at 04:23:46PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > This new struct will be the storage of src and dst coordinates > between the check and commit stages of a plane update. > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > --- > drivers/gpu/drm/i915/intel_drv.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 4ab0d92..59c1675 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -33,6 +33,7 @@ > #include <drm/drm_crtc_helper.h> > #include <drm/drm_fb_helper.h> > #include <drm/drm_dp_mst_helper.h> > +#include <drm/drm_rect.h> > > /** > * _wait_for - magic (register) wait macro > @@ -227,6 +228,25 @@ typedef struct dpll { > int p; > } intel_clock_t; > > +struct intel_plane_state { > + struct drm_crtc *crtc; > + struct drm_framebuffer *fb; > + int crtc_x; > + int crtc_y; > + unsigned int crtc_w; > + unsigned int crtc_h; > + uint32_t src_x; > + uint32_t src_y; > + uint32_t src_w; > + uint32_t src_h; Seems to me we shouldn't need these non-drm_rect coordinates in this struct. I'll comment a bit more on the next patch since that's where this is used. > + struct drm_rect src; > + struct drm_rect dst; > + struct drm_rect clip; > + struct drm_rect orig_src; > + struct drm_rect orig_dst; > + bool visible; > +}; > + > struct intel_plane_config { > bool tiled; > int size; > -- > 1.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 4ab0d92..59c1675 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -33,6 +33,7 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> #include <drm/drm_dp_mst_helper.h> +#include <drm/drm_rect.h> /** * _wait_for - magic (register) wait macro @@ -227,6 +228,25 @@ typedef struct dpll { int p; } intel_clock_t; +struct intel_plane_state { + struct drm_crtc *crtc; + struct drm_framebuffer *fb; + int crtc_x; + int crtc_y; + unsigned int crtc_w; + unsigned int crtc_h; + uint32_t src_x; + uint32_t src_y; + uint32_t src_w; + uint32_t src_h; + struct drm_rect src; + struct drm_rect dst; + struct drm_rect clip; + struct drm_rect orig_src; + struct drm_rect orig_dst; + bool visible; +}; + struct intel_plane_config { bool tiled; int size;