diff mbox

[6/8] drm/i915: Disable power management for i915 driver in VM

Message ID 1411152428-7226-7-git-send-email-jike.song@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jike Song Sept. 19, 2014, 6:47 p.m. UTC
From: Yu Zhang <yu.c.zhang@intel.com>

In XenGT, GPU power management is controlled by host i915
driver, so there is no need to provide virtualized GPU PM
support. In the future it might be useful to gather VM
input for freq boost, but now let's disable it simply.

Signed-off-by: Yu Zhang <yu.c.zhang@intel.com>
Signed-off-by: Jike Song <jike.song@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Chris Wilson Sept. 19, 2014, 8:16 a.m. UTC | #1
On Sat, Sep 20, 2014 at 02:47:06AM +0800, Jike Song wrote:
> From: Yu Zhang <yu.c.zhang@intel.com>
> 
> In XenGT, GPU power management is controlled by host i915
> driver, so there is no need to provide virtualized GPU PM
> support. In the future it might be useful to gather VM
> input for freq boost, but now let's disable it simply.
> 
> Signed-off-by: Yu Zhang <yu.c.zhang@intel.com>
> Signed-off-by: Jike Song <jike.song@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 675e8a2..1535fa3 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5419,6 +5419,12 @@ void intel_enable_gt_powersave(struct drm_device *dev)
>  		mutex_unlock(&dev->struct_mutex);
>  	} else if (INTEL_INFO(dev)->gen >= 6) {
>  		/*
> +		 * Powersaving is disabled when running inside a VM.
> +		 */
> +		if (intel_vgpu_active(dev))
> +			return;

Don't special case this to gen6+, it always applies because the comment
is not accurate, whereas the changelog is a much more apt description.

/* Powersaving is controlled by the host when inside a VM */
if (intel_vgpu_active(dev))
	return;
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 675e8a2..1535fa3 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5419,6 +5419,12 @@  void intel_enable_gt_powersave(struct drm_device *dev)
 		mutex_unlock(&dev->struct_mutex);
 	} else if (INTEL_INFO(dev)->gen >= 6) {
 		/*
+		 * Powersaving is disabled when running inside a VM.
+		 */
+		if (intel_vgpu_active(dev))
+			return;
+
+		/*
 		 * PCU communication is slow and this doesn't need to be
 		 * done at any specific time, so do this out of our fast path
 		 * to make resume and init faster.