From patchwork Tue Oct 21 16:58:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 5126461 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3B2999F30B for ; Tue, 21 Oct 2014 16:58:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 61AA7201F2 for ; Tue, 21 Oct 2014 16:58:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5129D200F4 for ; Tue, 21 Oct 2014 16:58:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C0D7898EE; Tue, 21 Oct 2014 09:58:56 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qa0-f50.google.com (mail-qa0-f50.google.com [209.85.216.50]) by gabe.freedesktop.org (Postfix) with ESMTP id CC2BC898EE for ; Tue, 21 Oct 2014 09:58:55 -0700 (PDT) Received: by mail-qa0-f50.google.com with SMTP id cs9so711227qab.37 for ; Tue, 21 Oct 2014 09:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5NL/ua1y9Z4BP354RirUHFnsyea5RRLFEOk+6jonMtk=; b=meQ0atVn7mHS/C4iig7fm5VUOBOrpDHNhuG+Iy3hhOQSXNRaan3AbkRDg9zXETbP5b U/izauMYrTyB82l4b/PKeD+dLigoeOzrAdwOVCSOSD8FD1XUSd2a/akspqLae7V3dB61 6Xl4zW3trp37mv+mm/7hBkWwXrnQoHo8pdyg8svNFpFzRXKH58MPpm2TjGvllCFiAYED OPr8Bh4Hd5OhA+VSk6DhwPrBeLTvRLdSQvb/5iuX8LuT8WofhrxvV7o1V9WpMTjbZLPi YSRhRCYVvAjzXsO7eNbnYmw+uDe0YZ0ILHHgezo0453B1KO9Fd8Zmct8JBuV3anWjOdF EW2Q== X-Received: by 10.229.180.8 with SMTP id bs8mr3322739qcb.17.1413910730638; Tue, 21 Oct 2014 09:58:50 -0700 (PDT) Received: from localhost.localdomain ([187.59.149.157]) by mx.google.com with ESMTPSA id j2sm11135997qab.39.2014.10.21.09.58.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Oct 2014 09:58:50 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Tue, 21 Oct 2014 14:58:08 -0200 Message-Id: <1413910688-1951-1-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH] drm/i915: add missing forcewake put on i915_wa_registers() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni Otherwise, a simple "cat" to the debugfs file can make the machine use much more power than needed, and prevent it from runtime suspending. Related commit: commit 8452e1d173a16d9812422a2272c4ab0f0ba81057 Author: Mika Kuoppala Date: Tue Oct 7 17:21:26 2014 +0300 drm/i915: Build workaround list in ring initialization Cc: Mika Kuoppala Cc: Arun Siluvery Testcase: igt/pm_rpm/debugfs-read Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 9600285..36a4baa 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -2671,6 +2671,7 @@ static int i915_wa_registers(struct seq_file *m, void *unused) addr, value, mask, read, ok ? "OK" : "FAIL"); } + gen6_gt_force_wake_put(dev_priv, FORCEWAKE_ALL); intel_runtime_pm_put(dev_priv); mutex_unlock(&dev->struct_mutex);