| Message ID | 1422288186-28168-4-git-send-email-mika.kuoppala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 26, 2015 at 06:03:06PM +0200, Mika Kuoppala wrote: > We have had %x and %u intermixed. Bring everything in line and > use %x > > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> Thanks, these had been annoying me for ages. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5645
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -1 353/353 352/353
ILK 353/353 353/353
SNB -1 400/422 399/422
IVB +2-2 485/487 485/487
BYT 296/296 296/296
HSW +1-1 507/508 507/508
BDW 401/402 401/402
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gen3_render_linear_blits PASS(3, M25M23) CRASH(1, M23)
*SNB igt_gem_concurrent_blit_gpu-bcs-gpu-read-after-write PASS(2, M35) NO_RESULT(1, M35)
*IVB igt_gem_persistent_relocs_forked-thrashing PASS(2, M34M4) NO_RESULT(1, M4)
IVB igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance DMESG_WARN(2, M34)PASS(3, M4) PASS(1, M4)
IVB igt_gem_storedw_batches_loop_normal DMESG_WARN(2, M34M4)PASS(5, M34M4M21) PASS(1, M4)
*IVB igt_gem_storedw_loop_blt PASS(2, M34M4) DMESG_WARN(1, M4)
HSW igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance DMESG_WARN(1, M40)PASS(7, M40M20) PASS(1, M40)
*HSW igt_pm_rpm_debugfs-read PASS(2, M40) DMESG_WARN(1, M40)
Note: You need to pay more attention to line start with '*'
On Wed, 28 Jan 2015, shuang.he@intel.com wrote: > Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) > Task id: 5645 > -------------------------------------Summary------------------------------------- > Platform Delta drm-intel-nightly Series Applied > PNV -1 353/353 352/353 > ILK 353/353 353/353 > SNB -1 400/422 399/422 > IVB +2-2 485/487 485/487 > BYT 296/296 296/296 > HSW +1-1 507/508 507/508 > BDW 401/402 401/402 > -------------------------------------Detailed------------------------------------- > Platform Test drm-intel-nightly Series Applied > *PNV igt_gen3_render_linear_blits PASS(3, M25M23) CRASH(1, M23) > *SNB igt_gem_concurrent_blit_gpu-bcs-gpu-read-after-write PASS(2, M35) NO_RESULT(1, M35) > *IVB igt_gem_persistent_relocs_forked-thrashing PASS(2, M34M4) NO_RESULT(1, M4) > IVB igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance DMESG_WARN(2, M34)PASS(3, M4) PASS(1, M4) > IVB igt_gem_storedw_batches_loop_normal DMESG_WARN(2, M34M4)PASS(5, M34M4M21) PASS(1, M4) > *IVB igt_gem_storedw_loop_blt PASS(2, M34M4) DMESG_WARN(1, M4) > HSW igt_gem_pwrite_pread_snooped-pwrite-blt-cpu_mmap-performance DMESG_WARN(1, M40)PASS(7, M40M20) PASS(1, M40) > *HSW igt_pm_rpm_debugfs-read PASS(2, M40) DMESG_WARN(1, M40) > Note: You need to pay more attention to line start with '*' This bug was not found by prts: https://bugs.freedesktop.org/show_bug.cgi?id=88908 Jani.
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index f865cfd..28316c7 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,7 +123,7 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; - seq_printf(m, "%pK: %s%s%s %8zdKiB %02x %02x %u %u %u%s%s%s", + seq_printf(m, "%pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s", &obj->base, get_pin_flag(obj), get_tiling_flag(obj), @@ -569,7 +569,7 @@ static int i915_gem_pageflip_info(struct seq_file *m, void *data) struct intel_engine_cs *ring = i915_gem_request_get_ring(work->flip_queued_req); - seq_printf(m, "Flip queued on %s at seqno %u, next seqno %u [current breadcrumb %u], completed? %d\n", + seq_printf(m, "Flip queued on %s at seqno %x, next seqno %x [current breadcrumb %x], completed? %d\n", ring->name, i915_gem_request_get_seqno(work->flip_queued_req), dev_priv->next_seqno, @@ -658,7 +658,7 @@ static int i915_gem_request_info(struct seq_file *m, void *data) list_for_each_entry(gem_request, &ring->request_list, list) { - seq_printf(m, " %d @ %d\n", + seq_printf(m, " %x @ %d\n", gem_request->seqno, (int) (jiffies - gem_request->emitted_jiffies)); } @@ -676,7 +676,7 @@ static void i915_ring_seqno_info(struct seq_file *m, struct intel_engine_cs *ring) { if (ring->get_seqno) { - seq_printf(m, "Current sequence (%s): %u\n", + seq_printf(m, "Current sequence (%s): %x\n", ring->name, ring->get_seqno(ring, false)); } }
We have had %x and %u intermixed. Bring everything in line and use %x Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)