diff mbox

[08/18] drm/i915/skl: Document that we implement WaRsClearFWBitsAtReset

Message ID 1423510402-12605-9-git-send-email-damien.lespiau@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lespiau, Damien Feb. 9, 2015, 7:33 p.m. UTC 
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nick Hoath Feb. 11, 2015, 3:08 p.m. UTC | #1 
On 09/02/2015 19:33, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Nick Hoath <nicholas.hoath@intel.com>

> ---
>   drivers/gpu/drm/i915/intel_uncore.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index c47a3ba..ad71575 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -972,6 +972,7 @@ static void fw_domain_init(struct drm_i915_private *dev_priv,
>   		d->val_set = FORCEWAKE_KERNEL;
>   		d->val_clear = 0;
>   	} else {
> +		/* WaRsClearFWBitsAtReset:bdw,skl */
>   		d->val_reset = _MASKED_BIT_DISABLE(0xffff);
>   		d->val_set = _MASKED_BIT_ENABLE(FORCEWAKE_KERNEL);
>   		d->val_clear = _MASKED_BIT_DISABLE(FORCEWAKE_KERNEL);
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index c47a3ba..ad71575 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -972,6 +972,7 @@  static void fw_domain_init(struct drm_i915_private *dev_priv,
 		d->val_set = FORCEWAKE_KERNEL;
 		d->val_clear = 0;
 	} else {
+		/* WaRsClearFWBitsAtReset:bdw,skl */
 		d->val_reset = _MASKED_BIT_DISABLE(0xffff);
 		d->val_set = _MASKED_BIT_ENABLE(FORCEWAKE_KERNEL);
 		d->val_clear = _MASKED_BIT_DISABLE(FORCEWAKE_KERNEL);