From patchwork Fri Feb 27 02:43:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Herbert X-Patchwork-Id: 5897401 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 96416BF440 for ; Fri, 27 Feb 2015 02:43:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DB39D20219 for ; Fri, 27 Feb 2015 02:43:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A0FE620212 for ; Fri, 27 Feb 2015 02:43:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2B9A89A32; Thu, 26 Feb 2015 18:43:51 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 78AFF898E4 for ; Thu, 26 Feb 2015 18:43:50 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 26 Feb 2015 18:38:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,656,1418112000"; d="scan'208";a="691442290" Received: from mherber2-mobl.jf.intel.com ([10.7.202.94]) by orsmga002.jf.intel.com with ESMTP; 26 Feb 2015 18:43:49 -0800 From: Marc Herbert To: intel-gfx@lists.freedesktop.org Date: Thu, 26 Feb 2015 18:43:43 -0800 Message-Id: <1425005023-5041-1-git-send-email-marc.herbert@intel.com> X-Mailer: git-send-email 1.9.3 Cc: Marc Herbert Subject: [Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n") X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The bare "Test requirement: modes" message is too cryptic, I had to go and read the source code to understand the missing requirement. Signed-off-by: Marc Herbert --- If there is a different message that you would like to push yourself then please don't mind me - I think ANY message would do. tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index b843478..cae02e9 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -1544,7 +1544,7 @@ static int run_pair(int duration, int flags) /* If we have fewer than 2 connected outputs then we won't have any * configuration at all. So skip in that case. */ - igt_require(modes); + igt_require_f(modes, "At least two displays required\n"); duration = duration * 1000 / modes; duration = max(duration, 500);