From patchwork Wed Mar 25 21:50:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 6095321 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 52A279F440 for ; Wed, 25 Mar 2015 21:51:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B33A202F2 for ; Wed, 25 Mar 2015 21:51:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id BF1562037D for ; Wed, 25 Mar 2015 21:51:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD02E6E93B; Wed, 25 Mar 2015 14:51:49 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qg0-f45.google.com (mail-qg0-f45.google.com [209.85.192.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EBDD6E93A for ; Wed, 25 Mar 2015 14:51:46 -0700 (PDT) Received: by qgfa8 with SMTP id a8so63252647qgf.0 for ; Wed, 25 Mar 2015 14:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=mdzRXS1fHUFkKu4+sHV1sIMqTKZHMhWyawog7vMihC8=; b=OJTA+3wE4LgAKvb4qbbQWLTvIT3CjyhUpFkn3MePz/sOS4OY5LZtQfGOjOKK7At+U9 ROFQg4+kvCYXsHdw4ao1EFnptXYOFHYk4wKLLGnBxA4p7armE0XRog598PVjbsPb6SmH ojdnPGOu3ZItu4sTXerhFYI8u6YiE9mXZbTq0Vt8e/VghLPpk+FF128HWFQ7RNa+73I0 8ZrJrlxUhawAI7vg5bVBQaTKYDxEx71rHdNA/ts8fC0l05bzjLKcC98sR4l2rTta1pLh WrEdc9Q2hOtOZsadkbLJ1Te0PJ8awW/gYujVmSVIfVRMx/eaQQUIQAaf6tV904A08Aly t/xA== X-Received: by 10.55.42.27 with SMTP id q27mr23250850qkh.64.1427320305741; Wed, 25 Mar 2015 14:51:45 -0700 (PDT) Received: from localhost.localdomain ([187.121.139.226]) by mx.google.com with ESMTPSA id b52sm2308334qgb.16.2015.03.25.14.51.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Mar 2015 14:51:45 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Wed, 25 Mar 2015 18:50:36 -0300 Message-Id: <1427320239-25667-4-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427320239-25667-1-git-send-email-przanoni@gmail.com> References: <1427320239-25667-1-git-send-email-przanoni@gmail.com> MIME-Version: 1.0 Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 4/7] tests/kms_fbc_crc: also gem_sync() on exec_nop() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni When we're doing the context subtest, at the end of prepare_test() we exec a single nop batch on the front buffer, which invalidates FBC. With the new frontbuffer tracking scheme it may take a while for FBC to be reenabled, so we end up failing the first fbc_enabled() assertion inside test_crc(). Other possible implementations: - Call gem_sync() at the specific prepare_test() point, not at every exec_nop() call. - Change the fbc_enabled() assertion to wait_for_fbc_enabled() and give it a bigger timeout value. Signed-off-by: Paulo Zanoni --- tests/kms_fbc_crc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 11078e0..d81f4a2 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -155,6 +155,8 @@ static void exec_nop(data_t *data, uint32_t handle, drm_intel_context *context) intel_batchbuffer_flush_with_context(batch, context); intel_batchbuffer_free(batch); + + gem_sync(data->drm_fd, handle); } static void fill_render(data_t *data, uint32_t handle,