From patchwork Thu Apr 2 08:32:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Praveen Paneri X-Patchwork-Id: 6145151 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 81F539F350 for ; Thu, 2 Apr 2015 08:28:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C502720328 for ; Thu, 2 Apr 2015 08:28:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 046AF202C8 for ; Thu, 2 Apr 2015 08:28:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A2366E998; Thu, 2 Apr 2015 01:28:35 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id DC24C6E998 for ; Thu, 2 Apr 2015 01:28:33 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 02 Apr 2015 01:28:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,509,1422950400"; d="scan'208";a="689364125" Received: from intel-desktop.iind.intel.com ([10.223.82.37]) by fmsmga001.fm.intel.com with ESMTP; 02 Apr 2015 01:28:33 -0700 From: Praveen Paneri To: intel-gfx@lists.freedesktop.org Date: Thu, 2 Apr 2015 14:02:21 +0530 Message-Id: <1427963547-23614-7-git-send-email-praveen.paneri@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1427963547-23614-1-git-send-email-praveen.paneri@intel.com> References: <1427963547-23614-1-git-send-email-praveen.paneri@intel.com> Cc: Praveen Paneri Subject: [Intel-gfx] [PATCH 06/12] xf86drmSL: Check function return value X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Validate the return value of SLCreateEntry() before using it. Signed-off-by: Praveen Paneri --- xf86drmSL.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xf86drmSL.c b/xf86drmSL.c index acddb54..45f3906 100644 --- a/xf86drmSL.c +++ b/xf86drmSL.c @@ -139,6 +139,7 @@ void *drmSLCreate(void) list->magic = SL_LIST_MAGIC; list->level = 0; list->head = SLCreateEntry(SL_MAX_LEVEL, 0, NULL); + if (!list->head) return NULL; list->count = 0; for (i = 0; i <= SL_MAX_LEVEL; i++) list->head->forward[i] = NULL; @@ -205,6 +206,7 @@ int drmSLInsert(void *l, unsigned long key, void *value) } entry = SLCreateEntry(level, key, value); + if (!entry) return -ENOMEM; /* Fix up forward pointers */ for (i = 0; i <= level; i++) {