From patchwork Thu Apr 9 11:14:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Wood X-Patchwork-Id: 6187521 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DEDC7BF4A6 for ; Thu, 9 Apr 2015 11:14:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 235DE203AA for ; Thu, 9 Apr 2015 11:14:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4DD9B2037C for ; Thu, 9 Apr 2015 11:14:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D07326E777; Thu, 9 Apr 2015 04:14:35 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 704356E33F for ; Thu, 9 Apr 2015 04:14:34 -0700 (PDT) Received: by wiun10 with SMTP id n10so93552806wiu.1 for ; Thu, 09 Apr 2015 04:14:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=S4/HgqdZEYyJMNT+GKLnHPP7LhkVj0x7ldNlWCPNM+M=; b=hoNsfCAxG9RHGvZDpQM93plP7WjTUnexEw0iPXtHCjzu/5oHK77RiPpS1axk3UovAG /79CxecKv6kNJigC0BN97Bf/a/8ElGbuOj82M48MujKwoYr+a3PSTzw7Irs30+T5A8Q0 I8Yi0aB7L3Gu98VtgvmyMIEHNEpx/rwMc1NksmTYBGyGceD/FPEwU7HNLjJ3js3+UUUC FAlzH49KzZWnT+oAybai0DrbTEfOk1vJOsfjlS9iVrdddvu+b8fxlGRw3S0nbjgHUQ2d Vn1sTcQGJVDq33Hi/xdV5SeAtcacVHPK4lCjyq2Du3UWDfT1SjSICv4uydftrYEH4ukx UyvA== X-Gm-Message-State: ALoCoQl9lrbJXGlk8ivJBdYI2cu6QNl+J5n7Lr9YUwQ3QDKPyedZHfB9l1CaqBtIbxyVbLRl7SoK X-Received: by 10.194.24.103 with SMTP id t7mr58292556wjf.15.1428578073799; Thu, 09 Apr 2015 04:14:33 -0700 (PDT) Received: from pistachio.icx.intel.com ([83.217.123.106]) by mx.google.com with ESMTPSA id b10sm2259456wiz.9.2015.04.09.04.14.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2015 04:14:33 -0700 (PDT) From: Thomas Wood To: intel-gfx@lists.freedesktop.org Date: Thu, 9 Apr 2015 12:14:29 +0100 Message-Id: <1428578069-8698-2-git-send-email-thomas.wood@intel.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1428578069-8698-1-git-send-email-thomas.wood@intel.com> References: <1428578069-8698-1-git-send-email-thomas.wood@intel.com> Subject: [Intel-gfx] [PATCH i-g-t 2/2] lib: use test failure status for igt_set_timeout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use a failure status code for timeout to avoid confusion between tests that take too long to execute versus a failure due to an operation taking longer than expected. Signed-off-by: Thomas Wood --- lib/igt_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index f9e92c9..e5bda86 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1705,15 +1705,15 @@ out: static void igt_alarm_handler(int signal) { - /* exit with timeout status */ - igt_fail(IGT_EXIT_TIMEOUT); + /* exit with failure status */ + igt_fail(IGT_EXIT_FAILURE); } /** * igt_set_timeout: * @seconds: number of seconds before timeout * - * Fail a test and exit with #IGT_EXIT_TIMEOUT status after the specified + * Fail a test and exit with #IGT_EXIT_FAILURE status after the specified * number of seconds have elapsed. If the current test has subtests and the * timeout occurs outside a subtest, subsequent subtests will be skipped and * marked as failed.