diff mbox

[i-g-t,1/2] quick_dump: Don't allow undefined symbols in _chipset.so

Message ID 1429018492-13266-1-git-send-email-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ville Syrjälä April 14, 2015, 1:34 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Every time _chipset.so has undefined symbols we fail to notice it
at build time and then get to wonder why quick_dump fails to actually
work. Pass -Wl,--no-undefined to the linker to get a build time error
instead of the current runtime error.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tools/quick_dump/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/tools/quick_dump/Makefile.am b/tools/quick_dump/Makefile.am
index 641066d..fd023e7 100644
--- a/tools/quick_dump/Makefile.am
+++ b/tools/quick_dump/Makefile.am
@@ -4,7 +4,8 @@  dist_bin_SCRIPTS = quick_dump.py reg_access.py
 bin_SCRIPTS = chipset.py
 
 lib_LTLIBRARIES = I915ChipsetPython.la
-I915ChipsetPython_la_LDFLAGS = -module -avoid-version $(PYTHON_LDFLAGS)
+I915ChipsetPython_la_LDFLAGS = -module -avoid-version $(PYTHON_LDFLAGS) \
+	-Wl,--no-undefined
 I915ChipsetPython_la_SOURCES = chipset_macro_wrap.c
 nodist_I915ChipsetPython_la_SOURCES = chipset_wrap_python.c
 I915ChipsetPython_la_LIBADD =			\