diff mbox

drm/i915: CD clock frequency to debugfs

Message ID 1429862770-4242-2-git-send-email-mika.kahola@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kahola, Mika April 24, 2015, 8:06 a.m. UTC
This patch adds information on current CD clock
frequency to debugfs i915_frequency_info

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shuang He April 24, 2015, 11:07 a.m. UTC | #1
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6259
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  276/276              276/276
ILK                                  302/302              302/302
SNB                                  318/318              318/318
IVB                                  341/341              341/341
BYT                                  287/287              287/287
BDW                                  318/318              318/318
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
Note: You need to pay more attention to line start with '*'
Daniel Vetter May 4, 2015, 2:18 p.m. UTC | #2
On Fri, Apr 24, 2015 at 11:06:10AM +0300, Mika Kahola wrote:
> This patch adds information on current CD clock
> frequency to debugfs i915_frequency_info
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 9c2b9e4..18c7531 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1266,6 +1266,9 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
>  		seq_puts(m, "no P-state info available\n");
>  	}
>  
> +	seq_printf(m, "CD clock freq: %dkHz\n",
> +		   dev_priv->display.get_display_clock_speed(dev));

Shouldn't we also dump the computed/requested cdclk in
dev_priv->cdclk_freq while at it? Seems useful enough otherwise.
-Daniel

> +
>  out:
>  	intel_runtime_pm_put(dev_priv);
>  	return ret;
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Kahola, Mika May 5, 2015, 10:37 a.m. UTC | #3
On Mon, 2015-05-04 at 16:18 +0200, Daniel Vetter wrote:
> On Fri, Apr 24, 2015 at 11:06:10AM +0300, Mika Kahola wrote:
> > This patch adds information on current CD clock
> > frequency to debugfs i915_frequency_info
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 9c2b9e4..18c7531 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1266,6 +1266,9 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> >  		seq_puts(m, "no P-state info available\n");
> >  	}
> >  
> > +	seq_printf(m, "CD clock freq: %dkHz\n",
> > +		   dev_priv->display.get_display_clock_speed(dev));
> 
> Shouldn't we also dump the computed/requested cdclk in
> dev_priv->cdclk_freq while at it? Seems useful enough otherwise.
> -Daniel
Yes, that would be useful information. I'll throw a patch that covers these clocks as well.

-Mika-

> > +
> >  out:
> >  	intel_runtime_pm_put(dev_priv);
> >  	return ret;
> > -- 
> > 1.9.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 9c2b9e4..18c7531 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1266,6 +1266,9 @@  static int i915_frequency_info(struct seq_file *m, void *unused)
 		seq_puts(m, "no P-state info available\n");
 	}
 
+	seq_printf(m, "CD clock freq: %dkHz\n",
+		   dev_priv->display.get_display_clock_speed(dev));
+
 out:
 	intel_runtime_pm_put(dev_priv);
 	return ret;