| Message ID | 1432648639-14799-1-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 26, 2015 at 02:57:19PM +0100, Damien Lespiau wrote: > It was reported that this comment was confusing, and indeed it is. > > v2: (one year later!) Add the range for the DRM_I915_* iotcl defines > (Daniel) > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Queued for -next, thanks for the patch. -Daniel > --- > include/uapi/drm/i915_drm.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index 4851d66..6e1a2ed 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -171,8 +171,12 @@ typedef struct _drm_i915_sarea { > #define I915_BOX_TEXTURE_LOAD 0x8 > #define I915_BOX_LOST_CONTEXT 0x10 > > -/* I915 specific ioctls > - * The device specific ioctl range is 0x40 to 0x79. > +/* > + * i915 specific ioctls. > + * > + * The device specific ioctl range is [DRM_COMMAND_BASE, DRM_COMMAND_END) ie > + * [0x40, 0xa0) (a0 is excluded). The numbers below are defined as offset > + * against DRM_COMMAND_BASE and should be between [0x0, 0x60). > */ > #define DRM_I915_INIT 0x00 > #define DRM_I915_FLUSH 0x01 > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 4851d66..6e1a2ed 100644 --- a/include/uapi/drm/i915_drm.h +++ b/include/uapi/drm/i915_drm.h @@ -171,8 +171,12 @@ typedef struct _drm_i915_sarea { #define I915_BOX_TEXTURE_LOAD 0x8 #define I915_BOX_LOST_CONTEXT 0x10 -/* I915 specific ioctls - * The device specific ioctl range is 0x40 to 0x79. +/* + * i915 specific ioctls. + * + * The device specific ioctl range is [DRM_COMMAND_BASE, DRM_COMMAND_END) ie + * [0x40, 0xa0) (a0 is excluded). The numbers below are defined as offset + * against DRM_COMMAND_BASE and should be between [0x0, 0x60). */ #define DRM_I915_INIT 0x00 #define DRM_I915_FLUSH 0x01
It was reported that this comment was confusing, and indeed it is. v2: (one year later!) Add the range for the DRM_I915_* iotcl defines (Daniel) Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- include/uapi/drm/i915_drm.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)