From patchwork Fri Jun 19 16:43:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6646351 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 18B0CC0020 for ; Fri, 19 Jun 2015 16:40:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3C49C2089F for ; Fri, 19 Jun 2015 16:40:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 473F42087F for ; Fri, 19 Jun 2015 16:40:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B4EC26E1F3; Fri, 19 Jun 2015 09:40:22 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTP id E8AAC6E1F3 for ; Fri, 19 Jun 2015 09:40:21 -0700 (PDT) Received: by wgfq1 with SMTP id q1so47506132wgf.1 for ; Fri, 19 Jun 2015 09:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=mj/lZN7tppVwgTCTeAjiwJQWSch0wBNX8PJbOsTjIp4=; b=dpKQsaUj0/KkxdetcfooYIjhTrg5uHL7XJo0CCXJFLIIxW4T7O5+9h/OaLEJLZYO/2 QH2i+mNrfcwqVWMlYVr1u1QHznJq1AXd5vboL6XDzf52d7ltbv6qU89XI9/pnlNi8BZL dC3iyWFGfcsqr5lSZ5SW6OeaOuaXBRP1sCHgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mj/lZN7tppVwgTCTeAjiwJQWSch0wBNX8PJbOsTjIp4=; b=G/l+hQcL7g0GAwdLvDDpvuCss9vUjQ+8uZLuQCknzoyJ/ob3kyLe7Co3LnSe50FWHU cgvq3Vyl9MIZfWarr2BZgYhywrRR3WGUu8By+R72mAiykQXAy8IGymNOwPyo2HAihfEe sc1GWlf27EJVnAf8/e/OV+cclrorf+4RlXQZrd/ys2s2JXB7mfHc7Vxq0kIpMdD+vj9r M/d5q2ZFmVQxHstJJsgfK1XtXx+i+WRUmwh7/tKHK5yC4uKGOk6MPYgjdqOzJpn0qHPL BkfD4HylCaxQotpN1yH20PSpqfVLLVufZ/pR+jho4tTJvz2znkrCy1XOJB8pAxPeW8aN ADuQ== X-Gm-Message-State: ALoCoQmDtnJr2K6oH/rJRy6hbNlp3P2WdmDE6iiUTA5KEr3E4GKKoIsCzuQNoggyOpga1e4P8uPI X-Received: by 10.180.13.175 with SMTP id i15mr8332109wic.30.1434732021227; Fri, 19 Jun 2015 09:40:21 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by mx.google.com with ESMTPSA id i5sm4459778wic.10.2015.06.19.09.40.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jun 2015 09:40:20 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Fri, 19 Jun 2015 18:43:04 +0200 Message-Id: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.1.4 Cc: Daniel Vetter , stable@vger.kernel.org, Daniel Vetter Subject: [Intel-gfx] [PATCH] drm/i915: Officially give up on seqno coherency X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We've never figured out the magic trick to make irq vs. seqno updates coherent, only tricks to make it work. And since commit 094f9a54e35500739da185cdb78f2e92fc379458 Author: Chris Wilson Date: Wed Sep 25 17:34:55 2013 +0100 drm/i915: Fix __wait_seqno to use true infinite timeouts we automatically fall back to an irq augmented with polling scheme after the first missed interrupt. There's really nothing else we can do, hence tune down the message to informational level. It's still useful for users in case it reliable preceedes a hard system hang. Cc: Mark Janes Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e6bb72dca3ff..9350f2e5cd04 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2946,8 +2946,8 @@ static void i915_hangcheck_elapsed(struct work_struct *work) /* Issue a wake-up to catch stuck h/w. */ if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) { if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring))) - DRM_ERROR("Hangcheck timer elapsed... %s idle\n", - ring->name); + DRM_INFO("Hangcheck timer elapsed... %s idle\n", + ring->name); else DRM_INFO("Fake missed irq on %s\n", ring->name);