From patchwork Sat Jun 27 15:07:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lespiau, Damien" X-Patchwork-Id: 6685081 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 78AA19F401 for ; Sat, 27 Jun 2015 15:08:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A927720770 for ; Sat, 27 Jun 2015 15:08:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 88A452076E for ; Sat, 27 Jun 2015 15:08:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F03366E5BA; Sat, 27 Jun 2015 08:08:40 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C42A6E2C6 for ; Sat, 27 Jun 2015 08:08:39 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 27 Jun 2015 08:08:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,689,1427785200"; d="scan'208";a="515137033" Received: from kczmudzi-mobl4.amr.corp.intel.com (HELO strange.ger.corp.intel.com) ([10.252.53.243]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2015 08:08:38 -0700 From: Damien Lespiau To: intel-gfx@lists.freedesktop.org Date: Sat, 27 Jun 2015 16:07:59 +0100 Message-Id: <1435417696-28115-2-git-send-email-damien.lespiau@intel.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1435417696-28115-1-git-send-email-damien.lespiau@intel.com> References: <1435417696-28115-1-git-send-email-damien.lespiau@intel.com> Subject: [Intel-gfx] [PATCH i-g-t 01/18] stats: Zero the whole structure at init() time X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because the structure started small, I initialized every member directly, but that means that the new fields added weren't properly initialized (sigh!). Zero the whole thing first then. Also, the punishment for introducing a bug should be to write the corresponding unit test. It's not a perfect one, but I'll take it. Signed-off-by: Damien Lespiau --- lib/igt_stats.c | 4 +++- lib/tests/igt_stats.c | 11 +++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/igt_stats.c b/lib/igt_stats.c index 65c0ac6..67ee947 100644 --- a/lib/igt_stats.c +++ b/lib/igt_stats.c @@ -23,16 +23,18 @@ */ #include +#include #include "igt_core.h" #include "igt_stats.h" void igt_stats_init(igt_stats_t *stats, unsigned int capacity) { + memset(stats, 0, sizeof(*stats)); + stats->values = calloc(capacity, sizeof(*stats->values)); igt_assert(stats->values); stats->capacity = capacity; - stats->n_values = 0; } void igt_stats_fini(igt_stats_t *stats) diff --git a/lib/tests/igt_stats.c b/lib/tests/igt_stats.c index f9081c7..f76d334 100644 --- a/lib/tests/igt_stats.c +++ b/lib/tests/igt_stats.c @@ -25,6 +25,16 @@ #include "igt_core.h" #include "igt_stats.h" +/* Make sure we zero igt_stats_t fields at init() time */ +static void test_init_zero(void) +{ + igt_stats_t stats; + + stats.mean = 1.; + igt_stats_init(&stats, 2); + igt_assert(stats.mean == 0.); +} + static void test_mean(void) { igt_stats_t stats; @@ -103,6 +113,7 @@ static void test_std_deviation(void) igt_simple_main { + test_init_zero(); test_mean(); test_invalidate_mean(); test_std_deviation();