From patchwork Sat Jun 27 15:08:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lespiau, Damien" X-Patchwork-Id: 6685131 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BAC57C05AC for ; Sat, 27 Jun 2015 15:08:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E217D2076F for ; Sat, 27 Jun 2015 15:08:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0B16220761 for ; Sat, 27 Jun 2015 15:08:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 587C66E729; Sat, 27 Jun 2015 08:08:52 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id CEAC66E729 for ; Sat, 27 Jun 2015 08:08:49 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 27 Jun 2015 08:08:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,689,1427785200"; d="scan'208";a="515137069" Received: from kczmudzi-mobl4.amr.corp.intel.com (HELO strange.ger.corp.intel.com) ([10.252.53.243]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2015 08:08:49 -0700 From: Damien Lespiau To: intel-gfx@lists.freedesktop.org Date: Sat, 27 Jun 2015 16:08:06 +0100 Message-Id: <1435417696-28115-9-git-send-email-damien.lespiau@intel.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1435417696-28115-1-git-send-email-damien.lespiau@intel.com> References: <1435417696-28115-1-git-send-email-damien.lespiau@intel.com> Subject: [Intel-gfx] [PATCH i-g-t 08/18] stats: Factor out a fixture to initialize stats X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We're going to use this simple fixture once more, might as well make a function instead of copy/pasting code. Signed-off-by: Damien Lespiau --- lib/tests/igt_stats.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/lib/tests/igt_stats.c b/lib/tests/igt_stats.c index 5c5e86a..6916f25 100644 --- a/lib/tests/igt_stats.c +++ b/lib/tests/igt_stats.c @@ -25,6 +25,15 @@ #include "igt_core.h" #include "igt_stats.h" +static void push_fixture_1(igt_stats_t *stats) +{ + igt_stats_push(stats, 2); + igt_stats_push(stats, 4); + igt_stats_push(stats, 6); + igt_stats_push(stats, 8); + igt_stats_push(stats, 10); +} + /* Make sure we zero igt_stats_t fields at init() time */ static void test_init_zero(void) { @@ -54,15 +63,9 @@ static void test_mean(void) double mean; igt_stats_init(&stats, 5); - - igt_stats_push(&stats, 2); - igt_stats_push(&stats, 4); - igt_stats_push(&stats, 6); - igt_stats_push(&stats, 8); - igt_stats_push(&stats, 10); + push_fixture_1(&stats); mean = igt_stats_get_mean(&stats); - igt_assert(mean == (2 + 4 + 6 + 8 + 10) / 5.); igt_stats_fini(&stats); @@ -74,12 +77,7 @@ static void test_invalidate_mean(void) double mean1, mean2; igt_stats_init(&stats, 6); - - igt_stats_push(&stats, 2); - igt_stats_push(&stats, 4); - igt_stats_push(&stats, 6); - igt_stats_push(&stats, 8); - igt_stats_push(&stats, 10); + push_fixture_1(&stats); mean1 = igt_stats_get_mean(&stats); igt_assert(mean1 == (2 + 4 + 6 + 8 + 10) / 5.);