| Message ID | 1435926637-30892-4-git-send-email-david.s.gordon@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 03, 2015 at 01:30:25PM +0100, Dave Gordon wrote: > From: Alex Dai <yu.dai@intel.com> > > Two new module parameters: "enable_guc_submission" which will turn > on submission of batchbuffers via the GuC (when implemented), and > "guc_log_level" which controls the level of debugging logged by the > GuC and captured by the host. > > Signed-off-by: Alex Dai <yu.dai@intel.com> > Signed-off-by: Dave Gordon <david.s.gordon@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_params.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index b0bb07d..9618f57 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2599,6 +2599,8 @@ struct i915_params { > bool reset; > bool disable_display; > bool disable_vtd_wa; > + bool enable_guc_submission; > + int guc_log_level; > int use_mmio_flip; > int mmio_debug; > bool verbose_state_checks; > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 7983fe4..a8f48dd 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -53,6 +53,8 @@ struct i915_params i915 __read_mostly = { > .verbose_state_checks = 1, > .nuclear_pageflip = 0, > .edp_vswing = 0, > + .enable_guc_submission = false, > + .guc_log_level = -1, > }; > > module_param_named(modeset, i915.modeset, int, 0400); > @@ -186,3 +188,10 @@ MODULE_PARM_DESC(edp_vswing, > "Ignore/Override vswing pre-emph table selection from VBT " > "(0=use value from vbt [default], 1=low power swing(200mV)," > "2=default swing(400mV))"); > + > +module_param_named(enable_guc_submission, i915.enable_guc_submission, bool, 0400); Please mark this as _unsave, this isn't anything end-users should fiddle with. > +MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)"); > + > +module_param_named(guc_log_level, i915.guc_log_level, int, 0400); I think this one is ok without _unsave, we want users to be able to collect logfiles without panicking because it taints their kernel ;-) -Daniel > +MODULE_PARM_DESC(guc_log_level, > + "GuC firmware logging level (-1:disabled (default), 0-3:enabled)"); > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b0bb07d..9618f57 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2599,6 +2599,8 @@ struct i915_params { bool reset; bool disable_display; bool disable_vtd_wa; + bool enable_guc_submission; + int guc_log_level; int use_mmio_flip; int mmio_debug; bool verbose_state_checks; diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 7983fe4..a8f48dd 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -53,6 +53,8 @@ struct i915_params i915 __read_mostly = { .verbose_state_checks = 1, .nuclear_pageflip = 0, .edp_vswing = 0, + .enable_guc_submission = false, + .guc_log_level = -1, }; module_param_named(modeset, i915.modeset, int, 0400); @@ -186,3 +188,10 @@ MODULE_PARM_DESC(edp_vswing, "Ignore/Override vswing pre-emph table selection from VBT " "(0=use value from vbt [default], 1=low power swing(200mV)," "2=default swing(400mV))"); + +module_param_named(enable_guc_submission, i915.enable_guc_submission, bool, 0400); +MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)"); + +module_param_named(guc_log_level, i915.guc_log_level, int, 0400); +MODULE_PARM_DESC(guc_log_level, + "GuC firmware logging level (-1:disabled (default), 0-3:enabled)");