diff mbox

[2/3] drm/i915: fix intel_fb_obj_flush documentation

Message ID 1436389719-16392-2-git-send-email-przanoni@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paulo Zanoni July 8, 2015, 9:08 p.m. UTC
From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reported by the kbuild test robot.

Regression introduced by:
commit de152b627eb3018de91ec5c5a50b38e17d80a88b
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Tue Jul 7 16:28:51 2015 -0700
    drm/i915: Add origin to frontbuffer tracking flush

(I reviewed this commit, so it's also my fault)

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_frontbuffer.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rodrigo Vivi July 9, 2015, 5 p.m. UTC | #1
ops... Sorry..
I could swear I had added this... or probably forgot to send the version
that had it...

Anyway:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


On Wed, Jul 8, 2015 at 2:09 PM Paulo Zanoni <przanoni@gmail.com> wrote:

> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Reported by the kbuild test robot.
>
> Regression introduced by:
> commit de152b627eb3018de91ec5c5a50b38e17d80a88b
> Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Date:   Tue Jul 7 16:28:51 2015 -0700
>     drm/i915: Add origin to frontbuffer tracking flush
>
> (I reviewed this commit, so it's also my fault)
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_frontbuffer.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_frontbuffer.c
> b/drivers/gpu/drm/i915/intel_frontbuffer.c
> index 122533d..dc8f14d 100644
> --- a/drivers/gpu/drm/i915/intel_frontbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_frontbuffer.c
> @@ -136,6 +136,7 @@ static void intel_frontbuffer_flush(struct drm_device
> *dev,
>   * intel_fb_obj_flush - flush frontbuffer object
>   * @obj: GEM object to flush
>   * @retire: set when retiring asynchronous rendering
> + * @origin: which operation caused the flush
>   *
>   * This function gets called every time rendering on the given object has
>   * completed and frontbuffer caching can be started again. If @retire is
> true
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
Daniel Vetter July 9, 2015, 5:16 p.m. UTC | #2
On Thu, Jul 09, 2015 at 05:00:57PM +0000, Rodrigo Vivi wrote:
> ops... Sorry..
> I could swear I had added this... or probably forgot to send the version
> that had it...
> 
> Anyway:
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Queued for -next, thanks for the patch.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_frontbuffer.c b/drivers/gpu/drm/i915/intel_frontbuffer.c
index 122533d..dc8f14d 100644
--- a/drivers/gpu/drm/i915/intel_frontbuffer.c
+++ b/drivers/gpu/drm/i915/intel_frontbuffer.c
@@ -136,6 +136,7 @@  static void intel_frontbuffer_flush(struct drm_device *dev,
  * intel_fb_obj_flush - flush frontbuffer object
  * @obj: GEM object to flush
  * @retire: set when retiring asynchronous rendering
+ * @origin: which operation caused the flush
  *
  * This function gets called every time rendering on the given object has
  * completed and frontbuffer caching can be started again. If @retire is true