From patchwork Tue Aug 11 12:25:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Kuoppala X-Patchwork-Id: 6992101 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 128459F358 for ; Tue, 11 Aug 2015 12:25:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 38691205C2 for ; Tue, 11 Aug 2015 12:25:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4D3E2205C1 for ; Tue, 11 Aug 2015 12:25:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CC3E6E678; Tue, 11 Aug 2015 05:25:28 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 29DB66E678 for ; Tue, 11 Aug 2015 05:25:28 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 11 Aug 2015 05:25:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,652,1432623600"; d="scan'208";a="539753661" Received: from rosetta.fi.intel.com (HELO rosetta) ([10.237.72.89]) by FMSMGA003.fm.intel.com with ESMTP; 11 Aug 2015 05:25:27 -0700 Received: by rosetta (Postfix, from userid 1000) id 69DA980088; Tue, 11 Aug 2015 15:25:40 +0300 (EEST) From: Mika Kuoppala To: intel-gfx@lists.freedesktop.org Date: Tue, 11 Aug 2015 15:25:37 +0300 Message-Id: <1439295937-4707-1-git-send-email-mika.kuoppala@intel.com> X-Mailer: git-send-email 2.1.4 Subject: [Intel-gfx] [PATCH] lib/rendercopy_gen9: WaBindlessSurfaceStateModifyEnable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Don't set the size of bindless surface state on rendercopy. And as of doing so, take into account the workaround for setting the command size. This was tried during hunting for https://bugs.freedesktop.org/show_bug.cgi?id=89959. But no impact was found. Cc: Arun Siluvery Signed-off-by: Mika Kuoppala Reviewed-by: Arun Siluvery --- lib/rendercopy_gen9.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c index 0766192..4a4a604 100644 --- a/lib/rendercopy_gen9.c +++ b/lib/rendercopy_gen9.c @@ -511,7 +511,11 @@ gen7_emit_push_constants(struct intel_batchbuffer *batch) { static void gen9_emit_state_base_address(struct intel_batchbuffer *batch) { - OUT_BATCH(GEN6_STATE_BASE_ADDRESS | (19 - 2)); + + /* WaBindlessSurfaceStateModifyEnable:skl,bxt */ + /* The length has to be one less if we dont modify + bindless state */ + OUT_BATCH(GEN6_STATE_BASE_ADDRESS | (19 - 1 - 2)); /* general */ OUT_BATCH(0 | BASE_ADDRESS_MODIFY); @@ -544,9 +548,9 @@ gen9_emit_state_base_address(struct intel_batchbuffer *batch) { OUT_BATCH(1 << 12 | 1); /* Bindless surface state base address */ - OUT_BATCH(0 | BASE_ADDRESS_MODIFY); OUT_BATCH(0); - OUT_BATCH(0xfffff000); + OUT_BATCH(0); + OUT_BATCH(0); } static void