| Message ID | 1439471460-26881-1-git-send-email-mika.kuoppala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 13, 2015 at 04:11:00PM +0300, Mika Kuoppala wrote: > Fix > > commit 59cdc16b1a6f069f944ff17851a59edf8f72d45d > Author: Arun Siluvery <arun.siluvery@linux.intel.com> > Date: Fri Jul 31 16:27:07 2015 +0100 > > tools/null_state/gen9: Send atleast one valid component in VF state > > to honor the Reviewed-by, send all four components as noted by > Ben in his review. > > Cc: Ben Widawsky <benjamin.widawsky@intel.com> > Cc: Arun Siluvery <arun.siluvery@linux.intel.com> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> Thanks. (STILL in favor of just dropping it :P ) Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
On Thu, Aug 13, 2015 at 04:11:00PM +0300, Mika Kuoppala wrote: > Fix > > commit 59cdc16b1a6f069f944ff17851a59edf8f72d45d > Author: Arun Siluvery <arun.siluvery@linux.intel.com> > Date: Fri Jul 31 16:27:07 2015 +0100 > > tools/null_state/gen9: Send atleast one valid component in VF state > > to honor the Reviewed-by, send all four components as noted by > Ben in his review. > > Cc: Ben Widawsky <benjamin.widawsky@intel.com> > Cc: Arun Siluvery <arun.siluvery@linux.intel.com> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> Mika, did you forget something? The kernel patch? -Chris
On Fri, Nov 06, 2015 at 10:00:19PM +0000, Chris Wilson wrote: > On Thu, Aug 13, 2015 at 04:11:00PM +0300, Mika Kuoppala wrote: > > Fix > > > > commit 59cdc16b1a6f069f944ff17851a59edf8f72d45d > > Author: Arun Siluvery <arun.siluvery@linux.intel.com> > > Date: Fri Jul 31 16:27:07 2015 +0100 > > > > tools/null_state/gen9: Send atleast one valid component in VF state > > > > to honor the Reviewed-by, send all four components as noted by > > Ben in his review. > > > > Cc: Ben Widawsky <benjamin.widawsky@intel.com> > > Cc: Arun Siluvery <arun.siluvery@linux.intel.com> > > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> > > Mika, did you forget something? The kernel patch? > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre When you guys have a stable I-G-T I'd strongly advocate for removing null state on gen9 and seeing if it actually hurts anything.
diff --git a/tools/null_state_gen/intel_renderstate_gen9.c b/tools/null_state_gen/intel_renderstate_gen9.c index b3766ea..37bc675 100644 --- a/tools/null_state_gen/intel_renderstate_gen9.c +++ b/tools/null_state_gen/intel_renderstate_gen9.c @@ -442,7 +442,7 @@ int gen9_setup_null_render_state(struct intel_batchbuffer *batch) gen8_emit_vertex_elements(batch); OUT_BATCH(GEN9_3DSTATE_COMPONENT_PACKING | 3); - OUT_BATCH(1); + OUT_BATCH(0xf); OUT_BATCH(0); OUT_BATCH(0); OUT_BATCH(0);
Fix commit 59cdc16b1a6f069f944ff17851a59edf8f72d45d Author: Arun Siluvery <arun.siluvery@linux.intel.com> Date: Fri Jul 31 16:27:07 2015 +0100 tools/null_state/gen9: Send atleast one valid component in VF state to honor the Reviewed-by, send all four components as noted by Ben in his review. Cc: Ben Widawsky <benjamin.widawsky@intel.com> Cc: Arun Siluvery <arun.siluvery@linux.intel.com> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> --- tools/null_state_gen/intel_renderstate_gen9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)