diff mbox

[05/18] tests/drv_getparams: mark EU and subslice fetch as basic

Message ID 1439497901-14310-5-git-send-email-jbarnes@virtuousgeek.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes Aug. 13, 2015, 8:31 p.m. UTC
Fundamental and simple functionality.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 tests/drv_getparams.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Vetter Aug. 14, 2015, 12:27 p.m. UTC | #1
On Thu, Aug 13, 2015 at 01:31:28PM -0700, Jesse Barnes wrote:
> Fundamental and simple functionality.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Mark entire testcase as basic instead to catch future extensions?
getparams should always complete super-fast I think.
-Daniel

> ---
>  tests/drv_getparams.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/drv_getparams.c b/tests/drv_getparams.c
> index 31382e9..5a5c8bb 100644
> --- a/tests/drv_getparams.c
> +++ b/tests/drv_getparams.c
> @@ -157,9 +157,9 @@ igt_main
>  		init();
>  	}
>  
> -	igt_subtest("subslice-total")
> +	igt_subtest("basic-subslice-total")
>  		subslice_total();
>  
> -	igt_subtest("eu-total")
> +	igt_subtest("basic-eu-total")
>  		eu_total();
>  }
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jesse Barnes Aug. 14, 2015, 3:23 p.m. UTC | #2
On 08/14/2015 05:27 AM, Daniel Vetter wrote:
> On Thu, Aug 13, 2015 at 01:31:28PM -0700, Jesse Barnes wrote:
>> Fundamental and simple functionality.
>>
>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Mark entire testcase as basic instead to catch future extensions?
> getparams should always complete super-fast I think.

Sure, that works too.

Jesse
diff mbox

Patch

diff --git a/tests/drv_getparams.c b/tests/drv_getparams.c
index 31382e9..5a5c8bb 100644
--- a/tests/drv_getparams.c
+++ b/tests/drv_getparams.c
@@ -157,9 +157,9 @@  igt_main
 		init();
 	}
 
-	igt_subtest("subslice-total")
+	igt_subtest("basic-subslice-total")
 		subslice_total();
 
-	igt_subtest("eu-total")
+	igt_subtest("basic-eu-total")
 		eu_total();
 }