| Message ID | 1439497901-14310-8-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: > We should be able to create small and moderate sized objects quickly and > without errors. > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> They're all super-fast basic testcases for api cornercases. I'd vote to rename the entire testcase to gem_mmap_basic. -Daniel > --- > tests/gem_mmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/gem_mmap.c b/tests/gem_mmap.c > index 095f5b9..dd66ad6 100644 > --- a/tests/gem_mmap.c > +++ b/tests/gem_mmap.c > @@ -118,7 +118,7 @@ igt_main > igt_assert(ret == -1 && errno == ENOENT); > } > > - igt_subtest("new-object") { > + igt_subtest("basic") { > arg.handle = gem_create(fd, OBJECT_SIZE); > arg.offset = 0; > arg.size = OBJECT_SIZE; > @@ -154,7 +154,7 @@ igt_main > gem_close(fd, arg.handle); > } > > - igt_subtest("small-bo") > + igt_subtest("basic-small-bo") > test_huge_bo(fd, -1); > igt_subtest("big-bo") > test_huge_bo(fd, 0); > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Aug 14, 2015 at 02:33:25PM +0200, Daniel Vetter wrote: > On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: > > We should be able to create small and moderate sized objects quickly and > > without errors. > > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > They're all super-fast basic testcases for api cornercases. I'd vote to > rename the entire testcase to gem_mmap_basic. Hmm. Time to add another test, huger-bo. -Chris
On Fri, Aug 14, 2015 at 01:37:46PM +0100, Chris Wilson wrote: > On Fri, Aug 14, 2015 at 02:33:25PM +0200, Daniel Vetter wrote: > > On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: > > > We should be able to create small and moderate sized objects quickly and > > > without errors. > > > > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > > > They're all super-fast basic testcases for api cornercases. I'd vote to > > rename the entire testcase to gem_mmap_basic. > > Hmm. Time to add another test, huger-bo. Actually, the problem is that I broke the test... -Chris
On 08/14/2015 05:33 AM, Daniel Vetter wrote: > On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: >> We should be able to create small and moderate sized objects quickly and >> without errors. >> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > They're all super-fast basic testcases for api cornercases. I'd vote to > rename the entire testcase to gem_mmap_basic. Not quite, the huge ones were pretty slow in my measurements... Not as bad as suspend/resume, but not super fast either. Jesse
On Fri, Aug 14, 2015 at 08:31:53AM -0700, Jesse Barnes wrote: > On 08/14/2015 05:33 AM, Daniel Vetter wrote: > > On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: > >> We should be able to create small and moderate sized objects quickly and > >> without errors. > >> > >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > > > They're all super-fast basic testcases for api cornercases. I'd vote to > > rename the entire testcase to gem_mmap_basic. > > Not quite, the huge ones were pretty slow in my measurements... Not as > bad as suspend/resume, but not super fast either. Right I missed those two at the bottom. But everything above small-bo looks very basic, so perhaps just include them all with a basic-* prefix? And keep the first one as basic-new-object? -Daniel
diff --git a/tests/gem_mmap.c b/tests/gem_mmap.c index 095f5b9..dd66ad6 100644 --- a/tests/gem_mmap.c +++ b/tests/gem_mmap.c @@ -118,7 +118,7 @@ igt_main igt_assert(ret == -1 && errno == ENOENT); } - igt_subtest("new-object") { + igt_subtest("basic") { arg.handle = gem_create(fd, OBJECT_SIZE); arg.offset = 0; arg.size = OBJECT_SIZE; @@ -154,7 +154,7 @@ igt_main gem_close(fd, arg.handle); } - igt_subtest("small-bo") + igt_subtest("basic-small-bo") test_huge_bo(fd, -1); igt_subtest("big-bo") test_huge_bo(fd, 0);
We should be able to create small and moderate sized objects quickly and without errors. Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- tests/gem_mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)