| Message ID | 1443188026-1222-8-git-send-email-arun.siluvery@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 25, 2015 at 02:33:41PM +0100, Arun Siluvery wrote: > It is also applicable for B0. > > Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 9151a2b..be39f7ad 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev) > gen9_init_clock_gating(dev); > > /* WaDisableSDEUnitClockGating:bxt */ > - I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) | > - GEN8_SDEUNIT_CLOCK_GATE_DISABLE); > + if (INTEL_REVID(dev) >= BXT_REVID_A0) { I don't see a point in such a check. We don't have anything older than A stepping anyway, so this will always be true. Also BSpec says it's FROM_A0, w/a database says UNTIL_A0. Would be nice to know which is correct... > + I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) | > + GEN8_SDEUNIT_CLOCK_GATE_DISABLE)); > + } > > /* WaSetHDCunitClckGatingDisable:bxt */ > /* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */ > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On pe, 2015-09-25 at 14:33 +0100, Arun Siluvery wrote: > It is also applicable for B0. > > Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 9151a2b..be39f7ad 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev) > gen9_init_clock_gating(dev); > > /* WaDisableSDEUnitClockGating:bxt */ > - I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) | > - GEN8_SDEUNIT_CLOCK_GATE_DISABLE); > + if (INTEL_REVID(dev) >= BXT_REVID_A0) { This check looks redundant. > + I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) | > + GEN8_SDEUNIT_CLOCK_GATE_DISABLE)); > + } > > /* WaSetHDCunitClckGatingDisable:bxt */ > /* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */
On 28/09/2015 12:06, Imre Deak wrote: > On pe, 2015-09-25 at 14:33 +0100, Arun Siluvery wrote: >> It is also applicable for B0. >> >> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> >> --- >> drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> index 9151a2b..be39f7ad 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev) >> gen9_init_clock_gating(dev); >> >> /* WaDisableSDEUnitClockGating:bxt */ >> - I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) | >> - GEN8_SDEUNIT_CLOCK_GATE_DISABLE); >> + if (INTEL_REVID(dev) >= BXT_REVID_A0) { > > This check looks redundant. > Yes, I am removing it in v2. regards Arun >> + I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) | >> + GEN8_SDEUNIT_CLOCK_GATE_DISABLE)); >> + } >> >> /* WaSetHDCunitClckGatingDisable:bxt */ >> /* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */ > > >
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 9151a2b..be39f7ad 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev) gen9_init_clock_gating(dev); /* WaDisableSDEUnitClockGating:bxt */ - I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) | - GEN8_SDEUNIT_CLOCK_GATE_DISABLE); + if (INTEL_REVID(dev) >= BXT_REVID_A0) { + I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) | + GEN8_SDEUNIT_CLOCK_GATE_DISABLE)); + } /* WaSetHDCunitClckGatingDisable:bxt */ /* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */
It is also applicable for B0. Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> --- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)