| Message ID | 1445594525-7174-3-git-send-email-ander.conselvan.de.oliveira@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com> On 10/23/2015 3:31 PM, Ander Conselvan de Oliveira wrote: > Split the register write with the new link training pattern out of > intel_dp_set_link_train(), so that the i915 specific code is in a > separate function. > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 648300e..0958cab 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3594,20 +3594,28 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp) > intel_dp->DP = (intel_dp->DP & ~mask) | signal_levels; > } > > -static bool > -intel_dp_set_link_train(struct intel_dp *intel_dp, > - uint8_t dp_train_pat) > +static void > +intel_dp_program_link_training_pattern(struct intel_dp *intel_dp, > + uint8_t dp_train_pat) > { > struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > struct drm_i915_private *dev_priv = > to_i915(intel_dig_port->base.base.dev); > - uint8_t buf[sizeof(intel_dp->train_set) + 1]; > - int ret, len; > > _intel_dp_set_link_train(intel_dp, &intel_dp->DP, dp_train_pat); > > I915_WRITE(intel_dp->output_reg, intel_dp->DP); > POSTING_READ(intel_dp->output_reg); > +} > + > +static bool > +intel_dp_set_link_train(struct intel_dp *intel_dp, > + uint8_t dp_train_pat) > +{ > + uint8_t buf[sizeof(intel_dp->train_set) + 1]; > + int ret, len; > + > + intel_dp_program_link_training_pattern(intel_dp, dp_train_pat); > > buf[0] = dp_train_pat; > if ((dp_train_pat & DP_TRAINING_PATTERN_MASK) ==
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 648300e..0958cab 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3594,20 +3594,28 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp) intel_dp->DP = (intel_dp->DP & ~mask) | signal_levels; } -static bool -intel_dp_set_link_train(struct intel_dp *intel_dp, - uint8_t dp_train_pat) +static void +intel_dp_program_link_training_pattern(struct intel_dp *intel_dp, + uint8_t dp_train_pat) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); struct drm_i915_private *dev_priv = to_i915(intel_dig_port->base.base.dev); - uint8_t buf[sizeof(intel_dp->train_set) + 1]; - int ret, len; _intel_dp_set_link_train(intel_dp, &intel_dp->DP, dp_train_pat); I915_WRITE(intel_dp->output_reg, intel_dp->DP); POSTING_READ(intel_dp->output_reg); +} + +static bool +intel_dp_set_link_train(struct intel_dp *intel_dp, + uint8_t dp_train_pat) +{ + uint8_t buf[sizeof(intel_dp->train_set) + 1]; + int ret, len; + + intel_dp_program_link_training_pattern(intel_dp, dp_train_pat); buf[0] = dp_train_pat; if ((dp_train_pat & DP_TRAINING_PATTERN_MASK) ==
Split the register write with the new link training pattern out of intel_dp_set_link_train(), so that the i915 specific code is in a separate function. Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)