| Message ID | 1446535913-31970-3-git-send-email-maarten.lankhorst@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 03, 2015 at 08:31:41AM +0100, Maarten Lankhorst wrote: > Those platforms have the same bug as haswell, and the same fix applies to them. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91579 Sigh. Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 6e0a5683bbdc..825114af9c56 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -747,7 +747,7 @@ static int __intel_get_crtc_scanline(struct intel_crtc *crtc) > * problem. We may need to extend this to include other platforms, > * but so far testing only shows the problem on HSW. > */ > - if (IS_HASWELL(dev) && !position) { > + if (HAS_DDI(dev) && !position) { > int i, temp; > > for (i = 0; i < 100; i++) { > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, 03 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Tue, Nov 03, 2015 at 08:31:41AM +0100, Maarten Lankhorst wrote: >> Those platforms have the same bug as haswell, and the same fix applies to them. How about Broxton? IS_DDI matches that. Jani. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91579 > > Sigh. > Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> --- >> drivers/gpu/drm/i915/i915_irq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> index 6e0a5683bbdc..825114af9c56 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -747,7 +747,7 @@ static int __intel_get_crtc_scanline(struct intel_crtc *crtc) >> * problem. We may need to extend this to include other platforms, >> * but so far testing only shows the problem on HSW. >> */ >> - if (IS_HASWELL(dev) && !position) { >> + if (HAS_DDI(dev) && !position) { >> int i, temp; >> >> for (i = 0; i < 100; i++) { >> -- >> 2.1.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hey, Op 03-11-15 om 12:32 schreef Jani Nikula: > On Tue, 03 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >> On Tue, Nov 03, 2015 at 08:31:41AM +0100, Maarten Lankhorst wrote: >>> Those platforms have the same bug as haswell, and the same fix applies to them. > How about Broxton? IS_DDI matches that. > > Jani. > Judging from irc it's very likely it suffers from the same problem, but it would be nice if we had someone who could confirm. :)
On 11/03/2015 04:44 AM, Maarten Lankhorst wrote: > Hey, > > Op 03-11-15 om 12:32 schreef Jani Nikula: >> On Tue, 03 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >>> On Tue, Nov 03, 2015 at 08:31:41AM +0100, Maarten Lankhorst wrote: >>>> Those platforms have the same bug as haswell, and the same fix applies to them. >> How about Broxton? IS_DDI matches that. >> >> Jani. >> > Judging from irc it's very likely it suffers from the same problem, but it would be nice if we had someone who could confirm. :) It won't hurt (much) if we apply this workaround and it doesn't affect BXT, so I think we may as well apply given what we know of BXT's lineage. Jesse
On Thu, 05 Nov 2015, Jesse Barnes <jbarnes@virtuousgeek.org> wrote: > On 11/03/2015 04:44 AM, Maarten Lankhorst wrote: >> Hey, >> >> Op 03-11-15 om 12:32 schreef Jani Nikula: >>> On Tue, 03 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >>>> On Tue, Nov 03, 2015 at 08:31:41AM +0100, Maarten Lankhorst wrote: >>>>> Those platforms have the same bug as haswell, and the same fix applies to them. >>> How about Broxton? IS_DDI matches that. >>> >>> Jani. >>> >> Judging from irc it's very likely it suffers from the same problem, but it would be nice if we had someone who could confirm. :) > > It won't hurt (much) if we apply this workaround and it doesn't affect > BXT, so I think we may as well apply given what we know of BXT's lineage. Pushed this one patch to drm-intel-next-fixes, with cc: stable v4.3. BR, Jani.
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6e0a5683bbdc..825114af9c56 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -747,7 +747,7 @@ static int __intel_get_crtc_scanline(struct intel_crtc *crtc) * problem. We may need to extend this to include other platforms, * but so far testing only shows the problem on HSW. */ - if (IS_HASWELL(dev) && !position) { + if (HAS_DDI(dev) && !position) { int i, temp; for (i = 0; i < 100; i++) {
Those platforms have the same bug as haswell, and the same fix applies to them. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91579 --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)