From patchwork Wed Nov 4 09:35:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Fekete X-Patchwork-Id: 7548481 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2148ABEEA4 for ; Wed, 4 Nov 2015 09:33:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 536602061B for ; Wed, 4 Nov 2015 09:33:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4EEF320613 for ; Wed, 4 Nov 2015 09:33:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A3CC6E2C8; Wed, 4 Nov 2015 01:33:18 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A6736E2B4 for ; Wed, 4 Nov 2015 01:33:16 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 04 Nov 2015 01:33:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,242,1444719600"; d="scan'208";a="826680093" Received: from robertfe-linux.isw.intel.com ([10.237.180.144]) by fmsmga001.fm.intel.com with ESMTP; 04 Nov 2015 01:33:15 -0800 From: Robert Fekete To: intel-gfx@lists.freedesktop.org Date: Wed, 4 Nov 2015 10:35:19 +0100 Message-Id: <1446629719-1074-1-git-send-email-robert.fekete@linux.intel.com> X-Mailer: git-send-email 1.9.1 Subject: [Intel-gfx] [PATCH] drm/i915: Add some more bits to CURSOR_POS_MASK X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The old value of 0x7FF will wrap the position at 2048 giving wrong coordinate values on panels larger than 2048 pixels in any direction. Used in i915_debugfs atm. Looking at all hw specs available at 01.org shows that X position is bit 0:11, and even 0:12 on some hw where remaining bits up to bit 14 is MBZ. For Y position it is bits 16-27 where bits 28:30 is MBZ. It should be safe to increase CURSOR_POS_MASK to 13 bits (0x1FFF) making 8192 as a new wrap around value still getting valid cursor positions on platforms with only 12bits available thanks to MBZ on adjacent bits above. Signed-off-by: Robert Fekete Reviewed-by: Patrik Jakobsson --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 894253228947..f351f46f8cb9 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -4883,7 +4883,7 @@ enum skl_disp_power_wells { #define CURSOR_TRICKLE_FEED_DISABLE (1 << 14) #define _CURABASE 0x70084 #define _CURAPOS 0x70088 -#define CURSOR_POS_MASK 0x007FF +#define CURSOR_POS_MASK 0x01FFF #define CURSOR_POS_SIGN 0x8000 #define CURSOR_X_SHIFT 0 #define CURSOR_Y_SHIFT 16