diff mbox

drm/i915: quirk backlight present on Macbook 4, 1

Message ID 1446716999-1796-1-git-send-email-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula Nov. 5, 2015, 9:49 a.m. UTC
Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
know it in this case.

Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available according to VBT")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ander Conselvan de Oliveira Nov. 9, 2015, 8:57 a.m. UTC | #1
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote:
> Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
> know it in this case.
> 
> Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
> Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available
> according to VBT")
> Cc: stable@vger.kernel.org # v3.15+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 7b3cfb64e7f6..b067147183e9 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
>  	/* Apple Macbook 2,1 (Core 2 T7400) */
>  	{ 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
>  
> +	/* Apple Macbook 4,1 */
> +	{ 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
> +
>  	/* Toshiba CB35 Chromebook (Celeron 2955U) */
>  	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>
Jani Nikula Nov. 16, 2015, 12:49 p.m. UTC | #2
On Mon, 09 Nov 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

Pushed to drm-intel-fixes, thanks for the review.

BR,
Jani.


>
> On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote:
>> Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
>> know it in this case.
>> 
>> Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
>> Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available
>> according to VBT")
>> Cc: stable@vger.kernel.org # v3.15+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 7b3cfb64e7f6..b067147183e9 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
>>  	/* Apple Macbook 2,1 (Core 2 T7400) */
>>  	{ 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
>>  
>> +	/* Apple Macbook 4,1 */
>> +	{ 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
>> +
>>  	/* Toshiba CB35 Chromebook (Celeron 2955U) */
>>  	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7b3cfb64e7f6..b067147183e9 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14875,6 +14875,9 @@  static struct intel_quirk intel_quirks[] = {
 	/* Apple Macbook 2,1 (Core 2 T7400) */
 	{ 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
 
+	/* Apple Macbook 4,1 */
+	{ 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
+
 	/* Toshiba CB35 Chromebook (Celeron 2955U) */
 	{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },