diff mbox

drm/i915/skl: Add SKL GT4 PCI IDs

Message ID 1446811876-303-1-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Nov. 6, 2015, 12:11 p.m. UTC 
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Add Skylake Intel Graphics GT4 PCI IDs

v2: Rebase

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c |  1 +
 include/drm/i915_pciids.h       | 13 ++++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

Comments

Lespiau, Damien Dec. 4, 2015, 7 p.m. UTC | #1 
On Fri, Nov 06, 2015 at 02:11:16PM +0200, Mika Kuoppala wrote:
> From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> 
> Add Skylake Intel Graphics GT4 PCI IDs
> 
> v2: Rebase
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

>  drivers/gpu/drm/i915/i915_drv.c |  1 +
>  include/drm/i915_pciids.h       | 13 ++++++++++---
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 9f55209..59810b6 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -465,6 +465,7 @@ static const struct pci_device_id pciidlist[] = {
>  	INTEL_SKL_GT1_IDS(&intel_skylake_info),
>  	INTEL_SKL_GT2_IDS(&intel_skylake_info),
>  	INTEL_SKL_GT3_IDS(&intel_skylake_gt3_info),
> +	INTEL_SKL_GT4_IDS(&intel_skylake_gt3_info),
>  	INTEL_BXT_IDS(&intel_broxton_info),
>  	INTEL_KBL_GT1_IDS(&intel_kabylake_info),
>  	INTEL_KBL_GT2_IDS(&intel_kabylake_info),
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index f1a113e..f970209 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -279,12 +279,19 @@
>  #define INTEL_SKL_GT3_IDS(info) \
>  	INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
> -	INTEL_VGA_DEVICE(0x192A, info) /* SRV GT3 */ \
> +	INTEL_VGA_DEVICE(0x192A, info)  /* SRV GT3 */
>  
> -#define INTEL_SKL_IDS(info) \
> +#define INTEL_SKL_GT4_IDS(info) \
> +	INTEL_VGA_DEVICE(0x1932, info), /* DT GT4 */ \
> +	INTEL_VGA_DEVICE(0x193B, info), /* Halo GT4 */ \
> +	INTEL_VGA_DEVICE(0x193D, info), /* WKS GT4 */ \
> +	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4 */
> +
> +#define INTEL_SKL_IDS(info)	 \
>  	INTEL_SKL_GT1_IDS(info), \
>  	INTEL_SKL_GT2_IDS(info), \
> -	INTEL_SKL_GT3_IDS(info)
> +	INTEL_SKL_GT3_IDS(info), \
> +	INTEL_SKL_GT4_IDS(info)
>  
>  #define INTEL_BXT_IDS(info) \
>  	INTEL_VGA_DEVICE(0x0A84, info), \
> -- 
> 2.5.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Lespiau, Damien Dec. 4, 2015, 7:13 p.m. UTC | #2 
On Fri, Dec 04, 2015 at 07:00:36PM +0000, Damien Lespiau wrote:
> On Fri, Nov 06, 2015 at 02:11:16PM +0200, Mika Kuoppala wrote:
> > From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > 
> > Add Skylake Intel Graphics GT4 PCI IDs
> > 
> > v2: Rebase
> > 
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > ---
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

And picked up for dinq. Thanks!

I do wonder if it's a canditate for stable though. user land
drivers will lag behind...
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 9f55209..59810b6 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -465,6 +465,7 @@  static const struct pci_device_id pciidlist[] = {
 	INTEL_SKL_GT1_IDS(&intel_skylake_info),
 	INTEL_SKL_GT2_IDS(&intel_skylake_info),
 	INTEL_SKL_GT3_IDS(&intel_skylake_gt3_info),
+	INTEL_SKL_GT4_IDS(&intel_skylake_gt3_info),
 	INTEL_BXT_IDS(&intel_broxton_info),
 	INTEL_KBL_GT1_IDS(&intel_kabylake_info),
 	INTEL_KBL_GT2_IDS(&intel_kabylake_info),
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index f1a113e..f970209 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -279,12 +279,19 @@ 
 #define INTEL_SKL_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
-	INTEL_VGA_DEVICE(0x192A, info) /* SRV GT3 */ \
+	INTEL_VGA_DEVICE(0x192A, info)  /* SRV GT3 */
 
-#define INTEL_SKL_IDS(info) \
+#define INTEL_SKL_GT4_IDS(info) \
+	INTEL_VGA_DEVICE(0x1932, info), /* DT GT4 */ \
+	INTEL_VGA_DEVICE(0x193B, info), /* Halo GT4 */ \
+	INTEL_VGA_DEVICE(0x193D, info), /* WKS GT4 */ \
+	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4 */
+
+#define INTEL_SKL_IDS(info)	 \
 	INTEL_SKL_GT1_IDS(info), \
 	INTEL_SKL_GT2_IDS(info), \
-	INTEL_SKL_GT3_IDS(info)
+	INTEL_SKL_GT3_IDS(info), \
+	INTEL_SKL_GT4_IDS(info)
 
 #define INTEL_BXT_IDS(info) \
 	INTEL_VGA_DEVICE(0x0A84, info), \