From patchwork Fri Nov 13 12:05:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ander Conselvan de Oliveira X-Patchwork-Id: 7611081 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D756C9F392 for ; Fri, 13 Nov 2015 12:06:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B7F5204D9 for ; Fri, 13 Nov 2015 12:06:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A132B205F9 for ; Fri, 13 Nov 2015 12:06:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 513926E0B4; Fri, 13 Nov 2015 04:06:14 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AE5BA6E0B4 for ; Fri, 13 Nov 2015 04:06:12 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 13 Nov 2015 04:05:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,287,1444719600"; d="scan'208";a="850315026" Received: from linux.intel.com ([10.23.219.25]) by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2015 04:05:44 -0800 Received: from localhost (aconselv-mobl3.ger.corp.intel.com [10.237.66.45]) by linux.intel.com (Postfix) with ESMTP id C4BA56A4005; Fri, 13 Nov 2015 04:04:38 -0800 (PST) From: Ander Conselvan de Oliveira To: intel-gfx@lists.freedesktop.org Date: Fri, 13 Nov 2015 14:05:39 +0200 Message-Id: <1447416339-11419-1-git-send-email-ander.conselvan.de.oliveira@intel.com> X-Mailer: git-send-email 2.4.3 Cc: Ander Conselvan de Oliveira Subject: [Intel-gfx] [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Calling git --amend invokes the editor, which will not run if it relies on the terminal for input. So don't do that from dim_apply. Signed-off-by: Ander Conselvan de Oliveira --- dim | 2 -- 1 file changed, 2 deletions(-) diff --git a/dim b/dim index db92c57..893906b 100755 --- a/dim +++ b/dim @@ -382,8 +382,6 @@ function dim_apply if [ -n $message_id ]; then commit_add_tag "Link" "http://patchwork.freedesktop.org/patch/msgid/$message_id" fi - - git commit --amend & } function magic_patch