From patchwork Mon Nov 23 09:32:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7678581 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 78C019F1D3 for ; Mon, 23 Nov 2015 09:33:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9AAB820629 for ; Mon, 23 Nov 2015 09:33:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9D02920621 for ; Mon, 23 Nov 2015 09:33:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CFA0720CE; Mon, 23 Nov 2015 01:33:19 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55202720C4 for ; Mon, 23 Nov 2015 01:33:17 -0800 (PST) Received: by wmww144 with SMTP id w144so96092311wmw.0 for ; Mon, 23 Nov 2015 01:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=othRfdGfrnppWM7CmtQcMs9WzNXJONjDRTRRnDl5zr8=; b=UAJSwg2dTaviBgclKYVayhI7gO5KO3b/9L4th7tldf5UeOeUEt1nM2XscVj2XlrERG kKNoSf3TNNhbJko4F0xOuPDhzIV8YiAaCn7e/JPXqxLPbtX81NfI9Ep7qiaDyd5+ZSBJ jUoT7GNpk27WrqaIcgUmUhW2nw/gh8+XXXQRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=othRfdGfrnppWM7CmtQcMs9WzNXJONjDRTRRnDl5zr8=; b=lIT7a4eLCbVMLaw+nk6/N4eLBRsxArMhj0BVWDDpTehkT6DD3QNkMUDNZco3nd6ee2 v3drCXnzcKXlnjKs57TASTj4UDoWJri72XHMZmELv8m2lzRWs4gtCi4csdxBDjQAhEaO kMrytgGlJD2QgsGoTup7zd0Mtk7auA3N7M1yWTdalAApZxmPYnlgPhbHf3gkBmCwC9dn BOyhtjh0llGdpiNVg08yaxeavtFPPZ+iflMaK2g0QfRr/BNCLGhn8zA0jNFi9bo+WtmF oYONkIOuIfbPuCTM0gfk2H6t5Te57eS71rjPy8dv9UaO2UBANIm69yqAW29OyZdHOCZR DVJQ== X-Gm-Message-State: ALoCoQm1ymhu10cPycmUUgT9bSLqo9Qr9Ga3nFjR4khdbwieFklk7d+/hsIUgqBoo73/IkmLP3Sm X-Received: by 10.28.104.197 with SMTP id d188mr16077604wmc.55.1448271195992; Mon, 23 Nov 2015 01:33:15 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pn6sm12332758wjb.15.2015.11.23.01.33.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 01:33:15 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Mon, 23 Nov 2015 10:32:36 +0100 Message-Id: <1448271183-20523-4-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Tomi Valkeinen , Laurent Pinchart , Daniel Vetter Subject: [Intel-gfx] [PATCH 03/29] drm/omapdrm: Use unlocked gem unreferencing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For drm_gem_object_unreference callers are required to hold dev->struct_mutex, which these paths don't. Enforcing this requirement has become a bit more strict with commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference Cc: Tomi Valkeinen Cc: Laurent Pinchart Signed-off-by: Daniel Vetter --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index b8e4cdec28c3..c59090e8d23f 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -156,7 +156,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, /* note: if fb creation failed, we can't rely on fb destroy * to unref the bo: */ - drm_gem_object_unreference(fbdev->bo); + drm_gem_object_unreference_unlocked(fbdev->bo); ret = PTR_ERR(fb); goto fail; }