From patchwork Thu Dec 3 11:36:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sharma, Shashank" X-Patchwork-Id: 7758651 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 18FEABEEE1 for ; Thu, 3 Dec 2015 11:28:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 287EB2049D for ; Thu, 3 Dec 2015 11:28:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 448562042B for ; Thu, 3 Dec 2015 11:28:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82E0F7A120; Thu, 3 Dec 2015 03:28:06 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F363D7A120; Thu, 3 Dec 2015 03:28:04 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 03 Dec 2015 03:28:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; d="scan'208";a="6789988" Received: from shashanks-desktop.iind.intel.com ([10.223.26.81]) by fmsmga004.fm.intel.com with ESMTP; 03 Dec 2015 03:28:02 -0800 From: Shashank Sharma To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jim.bish@intel.com, robert.bradford@intel.com, matthew.d.roper@intel.com Date: Thu, 3 Dec 2015 17:06:44 +0530 Message-Id: <1449142621-16602-9-git-send-email-shashank.sharma@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449142621-16602-1-git-send-email-shashank.sharma@intel.com> References: <1449142621-16602-1-git-send-email-shashank.sharma@intel.com> Cc: emil.l.velikov@gmail.com, kausalmalladi@gmail.com, =gary.k.smith@intel.com, daniel.vetter@intel.com Subject: [Intel-gfx] [PATCH v8 08/25] drm: Add color correction state flag X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a color correction state flag, to indicate a change in color correction states. This flag will help a core driver to optimize its commit calls, by appling the color correction only when there is a change, not every commit. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_atomic.c | 6 ++++++ include/drm/drm_crtc.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 203a4a4..f6add78 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -456,18 +456,24 @@ int drm_atomic_crtc_set_property(struct drm_crtc *crtc, &state->palette_after_ctm_blob, val); if (ret) DRM_ERROR("Failed to load blob palette_after_ctm\n"); + else + state->color_correction_changed = true; return ret; } else if (property == config->cm_palette_before_ctm_property) { ret = drm_atomic_crtc_set_blob(dev, &state->palette_before_ctm_blob, val); if (ret) DRM_ERROR("Failed to load blob palette_before_ctm\n"); + else + state->color_correction_changed = true; return ret; } else if (property == config->cm_ctm_property) { ret = drm_atomic_crtc_set_blob(dev, &state->ctm_blob, val); if (ret) DRM_ERROR("Failed to load blob ctm\n"); + else + state->color_correction_changed = true; return ret; } else if (crtc->funcs->atomic_set_property) return crtc->funcs->atomic_set_property(crtc, state, property, val); diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 57c6650..867a134 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -263,6 +263,7 @@ struct drm_atomic_state; * @mode_changed: crtc_state->mode or crtc_state->enable has been changed * @active_changed: crtc_state->active has been toggled. * @connectors_changed: connectors to this crtc have been updated + * @color_correction_changed: color correction blob in this crtc got updated * @plane_mask: bitmask of (1 << drm_plane_index(plane)) of attached planes * @last_vblank_count: for helpers and drivers to capture the vblank of the * update to ensure framebuffer cleanup isn't done too early @@ -292,6 +293,7 @@ struct drm_crtc_state { bool mode_changed : 1; bool active_changed : 1; bool connectors_changed : 1; + bool color_correction_changed : 1; /* attached planes bitmask: * WARNING: transitional helpers do not maintain plane_mask so