diff mbox

drm/i915: Restore skl_gt3 device info

Message ID 1449242389-27076-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Dec. 4, 2015, 3:19 p.m. UTC 
This was broken in

commit 6a8beeffed3b2d33151150e3a03696e697f16d46
Author: Wayne Boyer <wayne.boyer@intel.com>
Date:   Wed Dec 2 13:28:14 2015 -0800

    drm/i915: Clean up device info structure definitions

and I didn't spot this while reviewing. We really need that CI farm up
asap!

Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Wayne Boyer <wayne.boyer@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lespiau, Damien Dec. 4, 2015, 3:46 p.m. UTC | #1 
On Fri, Dec 04, 2015 at 04:19:49PM +0100, Daniel Vetter wrote:
> This was broken in
> 
> commit 6a8beeffed3b2d33151150e3a03696e697f16d46
> Author: Wayne Boyer <wayne.boyer@intel.com>
> Date:   Wed Dec 2 13:28:14 2015 -0800
> 
>     drm/i915: Clean up device info structure definitions
> 
> and I didn't spot this while reviewing. We really need that CI farm up
> asap!

We had a BAT run on this one:

  http://patchwork.freedesktop.org/series/1360/

But no SKL GT3 coverage. Also, what seems to be flaky tests.
Daniel Vetter Dec. 4, 2015, 4:24 p.m. UTC | #2 
On Fri, Dec 04, 2015 at 03:46:29PM +0000, Damien Lespiau wrote:
> On Fri, Dec 04, 2015 at 04:19:49PM +0100, Daniel Vetter wrote:
> > This was broken in
> > 
> > commit 6a8beeffed3b2d33151150e3a03696e697f16d46
> > Author: Wayne Boyer <wayne.boyer@intel.com>
> > Date:   Wed Dec 2 13:28:14 2015 -0800
> > 
> >     drm/i915: Clean up device info structure definitions
> > 
> > and I didn't spot this while reviewing. We really need that CI farm up
> > asap!
> 
> We had a BAT run on this one:
> 
>   http://patchwork.freedesktop.org/series/1360/
> 
> But no SKL GT3 coverage. Also, what seems to be flaky tests.

Hm, still too much trouble with CRC based testcases ... That's not good,
given how much we rely on that stuff working for validating KMS features.
But at least it's improving I think.
-Daneil
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index d2d7e2461fa6..46ac66484dc7 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -324,6 +324,7 @@  static const struct intel_device_info intel_skylake_info = {
 };
 
 static const struct intel_device_info intel_skylake_gt3_info = {
+	HSW_FEATURES,
 	.is_skylake = 1,
 	.gen = 9,
 	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING | BSD2_RING,