| Message ID | 1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 06 Dec 2015, Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> wrote: > From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com> > > Signed-off-by: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com> I'd like to see a commit message describing what is done and why, even for trivial changes. Now the subject line is essentially the diff in plain English, which adds no information to the patch itself. It doesn't even say that this should be a non-functional change. BR, Jani. > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 9461a23..16c8cf1 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -27,6 +27,7 @@ > * > */ > > +#include <linux/log2.h> > #include <drm/drmP.h> > #include "i915_drv.h" > #include <drm/i915_drm.h> > @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring) > * Only consider slices where one, and only one, subslice has 7 > * EUs > */ > - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1) > + if (!is_power_of_2(dev_priv->info.subslice_7eu[i])) > continue; > > /*
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 9461a23..16c8cf1 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -27,6 +27,7 @@ * */ +#include <linux/log2.h> #include <drm/drmP.h> #include "i915_drv.h" #include <drm/i915_drm.h> @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring) * Only consider slices where one, and only one, subslice has 7 * EUs */ - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1) + if (!is_power_of_2(dev_priv->info.subslice_7eu[i])) continue; /*