From patchwork Tue Dec 8 08:49:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7795771 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2B86F9F1C2 for ; Tue, 8 Dec 2015 08:49:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 53FF22034C for ; Tue, 8 Dec 2015 08:49:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 7A020204AE for ; Tue, 8 Dec 2015 08:49:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C05C96E2DE; Tue, 8 Dec 2015 00:49:37 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03C416E526 for ; Tue, 8 Dec 2015 00:49:35 -0800 (PST) Received: by wmuu63 with SMTP id u63so172108081wmu.0 for ; Tue, 08 Dec 2015 00:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2hNE40VF3EnZqs4kIjRshNWTegqhmUF9yQ72QXFL1qE=; b=HR09oDSuU2JchVz5KR2yjph3jmw31i/6Md+5/UrS2U0AAQF4HdZqA+OwbDPJ6NA1bo WKaZDBqw83dEMjvxtHPMUtQfMJP52CCAs0xkmwg1dqlEz8RD8I+SuRVkjBjjhxeR+sra lIh9sB6y51c3WhLbSkm+FO8Yw1sag/vSAwxHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2hNE40VF3EnZqs4kIjRshNWTegqhmUF9yQ72QXFL1qE=; b=Pq3cpYHZbybpvTZ/UQm39ABdeE7WWtC73clnWK70c/m+YsnzuDbyp2uTtMqXBYOYXe ImfdHsmQNnt7ZgJRnRZ48biM6m2O/xbSOlQXtvLF8GzEqBpPcFqzup7jXa54MKK72O0X iTfowfg1YtWB4JhaFS1XqBls2o4qlaS31sHAXaQ7XIz7vNueKxQvwxTdQYdoeyLY6mfU fQt+08LrYp2ZBGMNODqr8ayJfsLmFTdph3rNj4AhHmc57ZA1yX++VOuYvEFiCcq/REEI MpltpaX4iSehdDa+LICLT7B/RoAvwSh8HYNU5uiIeijoLDRgkqLxgPAce8vk2fHhc3pQ eBZg== X-Gm-Message-State: ALoCoQl2/t3EZCRqjz+9ILAczXt/jLmzJemlLje/K4xC+6M4uLTWxmpjAvPVuyvp0E2H+sFlxqPeUuZ0GOduvT/60kbIWCN7wA== X-Received: by 10.194.120.226 with SMTP id lf2mr2420246wjb.108.1449564573752; Tue, 08 Dec 2015 00:49:33 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id e83sm2393423wmc.23.2015.12.08.00.49.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Dec 2015 00:49:33 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Tue, 8 Dec 2015 09:49:21 +0100 Message-Id: <1449564561-3896-5-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1449564561-3896-1-git-send-email-daniel.vetter@ffwll.ch> References: <1449564561-3896-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Stephen Rothwell , Daniel Vetter , Intel Graphics Development , Thierry Reding , Russell King , Daniel Vetter Subject: [Intel-gfx] [PATCH 5/5] drm/tda998x: Remove dummy save/restore funcs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In my quest to remove all the drm_encoder_helper_funcs->save/restore hooks I somehow missed that this driver has a dummy set too - I thought all the i2c drivers only set up the slave_encoder save/restore hooks, which I've left. Remove them. Reported-by: Stephen Rothwell Cc: Stephen Rothwell Cc: Thierry Reding Cc: Russell King Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i2c/tda998x_drv.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 896b6aaf8c4d..79cb9208530e 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -855,18 +855,6 @@ static void tda998x_encoder_dpms(struct drm_encoder *encoder, int mode) priv->dpms = mode; } -static void -tda998x_encoder_save(struct drm_encoder *encoder) -{ - DBG(""); -} - -static void -tda998x_encoder_restore(struct drm_encoder *encoder) -{ - DBG(""); -} - static bool tda998x_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, @@ -1351,8 +1339,6 @@ static void tda998x_encoder_commit(struct drm_encoder *encoder) static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = { .dpms = tda998x_encoder_dpms, - .save = tda998x_encoder_save, - .restore = tda998x_encoder_restore, .mode_fixup = tda998x_encoder_mode_fixup, .prepare = tda998x_encoder_prepare, .commit = tda998x_encoder_commit,