diff mbox

[6/7] drm/i915: Add unclaimed mmio check to runtime pm get/put

Message ID 1450189512-30360-6-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Dec. 15, 2015, 2:25 p.m. UTC 
This is a natural boundary to peek if our power domain
management is accurate.

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Chris Wilson Dec. 15, 2015, 2:33 p.m. UTC | #1 
On Tue, Dec 15, 2015 at 04:25:11PM +0200, Mika Kuoppala wrote:
> This is a natural boundary to peek if our power domain
> management is accurate.

No, I have plans for this to be very frequent. In that bold plan,
the suspend/resume boundary is more sensible.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 2c2151f..5eea177 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -2230,6 +2230,7 @@  void intel_runtime_pm_get(struct drm_i915_private *dev_priv)
 		return;
 
 	pm_runtime_get_sync(device);
+	WARN_ON(intel_uncore_arm_unclaimed_mmio_detection(dev_priv));
 	WARN(dev_priv->pm.suspended, "Device still suspended.\n");
 }
 
@@ -2275,6 +2276,8 @@  void intel_runtime_pm_put(struct drm_i915_private *dev_priv)
 	struct drm_device *dev = dev_priv->dev;
 	struct device *device = &dev->pdev->dev;
 
+	WARN_ON(intel_uncore_arm_unclaimed_mmio_detection(dev_priv));
+
 	if (!HAS_RUNTIME_PM(dev))
 		return;