diff mbox

drm/i915: Tune down "GT register while GT waking disabled" message

Message ID 1453233656-12955-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Jan. 19, 2016, 8 p.m. UTC
We've had this since forever, and's randomly reporting issues and as
such causing piles&piles of CI noise. Mika is working on proper debug
infrastructure for this, and on fixing this properly.

Meanwhile make CI more useful for everyone else.

Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93121
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mika Kuoppala Jan. 20, 2016, 11:13 a.m. UTC | #1
Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> We've had this since forever, and's randomly reporting issues and as
> such causing piles&piles of CI noise. Mika is working on proper debug
> infrastructure for this, and on fixing this properly.
>
> Meanwhile make CI more useful for everyone else.
>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93121
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

We should have soon way to do research on this without
harming ci/bat. So for denoising:

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 760e0ce4aa26..f1cab9f131ae 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1384,7 +1384,7 @@ static void vlv_check_no_gt_access(struct drm_i915_private *dev_priv)
>  	if (!(I915_READ(VLV_GTLC_PW_STATUS) & VLV_GTLC_ALLOWWAKEERR))
>  		return;
>  
> -	DRM_ERROR("GT register access while GT waking disabled\n");
> +	DRM_DEBUG_DRIVER("GT register access while GT waking disabled\n");
>  	I915_WRITE(VLV_GTLC_PW_STATUS, VLV_GTLC_ALLOWWAKEERR);
>  }
>  
> -- 
> 2.7.0.rc3
Mika Kuoppala Jan. 21, 2016, 10:07 a.m. UTC | #2
Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:

> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
>> We've had this since forever, and's randomly reporting issues and as
>> such causing piles&piles of CI noise. Mika is working on proper debug
>> infrastructure for this, and on fixing this properly.
>>
>> Meanwhile make CI more useful for everyone else.
>>
>> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93121
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> We should have soon way to do research on this without
> harming ci/bat. So for denoising:
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>

Applied to dinq. Thanks for patch.

-Mika

>> ---
>>  drivers/gpu/drm/i915/i915_drv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 760e0ce4aa26..f1cab9f131ae 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1384,7 +1384,7 @@ static void vlv_check_no_gt_access(struct drm_i915_private *dev_priv)
>>  	if (!(I915_READ(VLV_GTLC_PW_STATUS) & VLV_GTLC_ALLOWWAKEERR))
>>  		return;
>>  
>> -	DRM_ERROR("GT register access while GT waking disabled\n");
>> +	DRM_DEBUG_DRIVER("GT register access while GT waking disabled\n");
>>  	I915_WRITE(VLV_GTLC_PW_STATUS, VLV_GTLC_ALLOWWAKEERR);
>>  }
>>  
>> -- 
>> 2.7.0.rc3
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 760e0ce4aa26..f1cab9f131ae 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1384,7 +1384,7 @@  static void vlv_check_no_gt_access(struct drm_i915_private *dev_priv)
 	if (!(I915_READ(VLV_GTLC_PW_STATUS) & VLV_GTLC_ALLOWWAKEERR))
 		return;
 
-	DRM_ERROR("GT register access while GT waking disabled\n");
+	DRM_DEBUG_DRIVER("GT register access while GT waking disabled\n");
 	I915_WRITE(VLV_GTLC_PW_STATUS, VLV_GTLC_ALLOWWAKEERR);
 }