| Message ID | 1453989852-13569-1-git-send-email-imre.deak@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Imre Deak <imre.deak@intel.com> writes: > Add PCIIDs for new versions of the SOC, based on BSpec. Also add the > name of the versions as code comment where this is available. The new > versions don't have any changes visible to the kernel driver. > > Signed-off-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com> > --- > include/drm/i915_pciids.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index f970209..9b48ac1 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -296,7 +296,9 @@ > #define INTEL_BXT_IDS(info) \ > INTEL_VGA_DEVICE(0x0A84, info), \ > INTEL_VGA_DEVICE(0x1A84, info), \ > - INTEL_VGA_DEVICE(0x5A84, info) > + INTEL_VGA_DEVICE(0x1A85, info), \ > + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \ > + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */ > > #define INTEL_KBL_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > -- > 2.5.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jan 28, 2016 at 04:04:12PM +0200, Imre Deak wrote: > Add PCIIDs for new versions of the SOC, based on BSpec. Also add the > name of the versions as code comment where this is available. The new > versions don't have any changes visible to the kernel driver. > > Signed-off-by: Imre Deak <imre.deak@intel.com> > --- > include/drm/i915_pciids.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index f970209..9b48ac1 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -296,7 +296,9 @@ > #define INTEL_BXT_IDS(info) \ > INTEL_VGA_DEVICE(0x0A84, info), \ > INTEL_VGA_DEVICE(0x1A84, info), \ > - INTEL_VGA_DEVICE(0x5A84, info) > + INTEL_VGA_DEVICE(0x1A85, info), \ I don't see 0x1A85 in the bspec (at least not in the "Configurations -> Steppings and Device IDs" section...is there another list elsewhere in the bspec you got it from?) Semi-related...the revision ID vs stepping info on that page doesn't seem to quite match what we have in bxt_stepping_info[] in intel_csr.c (plus it looks like we have some new revision ID's we could add in general). Matt > + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \ > + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */ > > #define INTEL_KBL_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > -- > 2.5.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On su, 2016-01-31 at 16:20 -0800, Matt Roper wrote: > On Thu, Jan 28, 2016 at 04:04:12PM +0200, Imre Deak wrote: > > Add PCIIDs for new versions of the SOC, based on BSpec. Also add > > the > > name of the versions as code comment where this is available. The > > new > > versions don't have any changes visible to the kernel driver. > > > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > --- > > include/drm/i915_pciids.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index f970209..9b48ac1 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -296,7 +296,9 @@ > > #define INTEL_BXT_IDS(info) \ > > INTEL_VGA_DEVICE(0x0A84, info), \ > > INTEL_VGA_DEVICE(0x1A84, info), \ > > - INTEL_VGA_DEVICE(0x5A84, info) > > + INTEL_VGA_DEVICE(0x1A85, info), \ > > I don't see 0x1A85 in the bspec (at least not in the "Configurations > -> > Steppings and Device IDs" section...is there another list elsewhere > in > the bspec you got it from?) Hm yes, it looks like it was left out from the first table, it is only listed under "Broxton SKUs and Device IDs". I opened a new issue on the relevant BSpec page. > Semi-related...the revision ID vs stepping info on that page doesn't > seem to quite match what we have in bxt_stepping_info[] in > intel_csr.c Hm good point. This depends on how the firmware versions will be packaged for the newer versions. It is possible that for the new steppings a default entry will be used, in which case we wouldn't have to encode the individual steppings. +Animesh. Animesh could you check the above and follow-up with a patch updating the table if necessary? > (plus it looks like we have some new revision ID's we could add in > general). The way we did this so far is to add encodings only for steppings that we need for a WA. There hasn't been any need for the newer steppings based on this. --Imre > Matt > > > + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ > > \ > > + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */ > > > > #define INTEL_KBL_GT1_IDS(info) \ > > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > > -- > > 2.5.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >
On pe, 2016-01-29 at 10:14 +0000, Patchwork wrote: > == Summary == > > Series 2901v1 drm/i915/bxt: update list of PCIIDs > http://patchwork.freedesktop.org/api/1.0/series/2901/revisions/1/mbox > / > > Test kms_flip: > Subgroup basic-flip-vs-dpms: > pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE > Test kms_pipe_crc_basic: > Subgroup nonblocking-crc-pipe-a: > skip -> PASS (byt-nuc) Thanks for the review, I pushed the patch to dinq. --Imre > > bdw- > nuci7 total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 > > bdw- > ultra total:159 pass:147 dwarn:0 dfail:0 fail:0 skip:1 > 2 > bsw-nuc- > 2 total:159 pass:129 dwarn:0 dfail:0 fail:0 skip:30 > byt- > nuc total:159 pass:136 dwarn:0 dfail:0 fail:0 skip:2 > 3 > hsw- > brixbox total:159 pass:146 dwarn:0 dfail:0 fail:0 skip:1 > 3 > hsw- > gt2 total:159 pass:149 dwarn:0 dfail:0 fail:0 skip:1 > 0 > ilk- > hp8440p total:159 pass:110 dwarn:1 dfail:0 fail:0 skip:4 > 8 > ivb- > t430s total:159 pass:145 dwarn:0 dfail:0 fail:0 skip:1 > 4 > skl-i5k- > 2 total:159 pass:144 dwarn:1 dfail:0 fail:0 skip:14 > snb- > dellxps total:159 pass:137 dwarn:0 dfail:0 fail:0 skip:2 > 2 > snb- > x220t total:159 pass:137 dwarn:0 dfail:0 fail:1 skip:2 > 1 > > Results at /archive/results/CI_IGT_test/Patchwork_1312/ > > 5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y- > 01m-29d-07h-32m-09s UTC integration manifest > 4632905fa2a81fe378d0170dcbb9733cec7726cf drm/i915/bxt: update list of > PCIIDs >
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index f970209..9b48ac1 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -296,7 +296,9 @@ #define INTEL_BXT_IDS(info) \ INTEL_VGA_DEVICE(0x0A84, info), \ INTEL_VGA_DEVICE(0x1A84, info), \ - INTEL_VGA_DEVICE(0x5A84, info) + INTEL_VGA_DEVICE(0x1A85, info), \ + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \ + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */ #define INTEL_KBL_GT1_IDS(info) \ INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
Add PCIIDs for new versions of the SOC, based on BSpec. Also add the name of the versions as code comment where this is available. The new versions don't have any changes visible to the kernel driver. Signed-off-by: Imre Deak <imre.deak@intel.com> --- include/drm/i915_pciids.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)